-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize #259
Conversation
pickle.load(open(file, "rb")) does not close the file
Fix computed Comp_Quat class and close pickle files
@javierggt - since I (somewhat accidentally) merged #260 into this PR there are unrelated commits now. You can probably just look at the 4 original commits in isolation since they are mostly independent of each other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are in the subject of modernization, the Counter
class you have here can be replaced with collections.defaultdifct
. Instead of:
ref_counter = Counter()
this:
ref_counter =collections.defaultdict(lambda : 0)
but I do not mind the Counter
class.
I would say using |
Description
This brings cheta up to modern-ish code standards.
__future__
imports andsix
imports.dev_utils
files.Interface impacts
None.
Testing
Unit tests
Independent check of unit tests by Javier
Functional tests
No functional testing.