Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ska api fixes #6

Merged
merged 12 commits into from
Jul 5, 2022
Merged

Ska api fixes #6

merged 12 commits into from
Jul 5, 2022

Conversation

javierggt
Copy link
Collaborator

@javierggt javierggt commented Jun 16, 2022

Description

This makes the following changes to the ska_api blueprint:

  • return error codes when there is an error
  • add a few more functions I want to use to the API:
    • agasc: get_star, get_stars, get_agasc_cone
    • mica.archive.aca_dark.dark_cal: get_dark_cal_ids, get_dark_cal_id, get_dark_cal_image, get_dark_cal_props
    • kadi.commands: get_observations, get_starcats
  • numpy arrays output from ska_api functions are now encoded
  • added ska_api unit tests

Interface impacts

  • Adds nine functions to the web API
  • The API can now return 500 error if the output cannot be encoded, unless the argument strict_encoding=false is passed

Testing

For testing, this requires sot/kadi/pull/241 and sot/mica/pull/273.

Astromon tests fail, but this is independent of this PR. For astromon tests to pass one needs sot/astromon/pull/26 and some test data.

Unit tests

  • On OS-X

Functional tests

@javierggt javierggt merged commit e09429f into main Jul 5, 2022
@javierggt javierggt deleted the ska-api-fixes branch July 6, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant