Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Include all weekly command loads starting from NOV2899 #250

Closed
wants to merge 7 commits into from

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Sep 6, 2022

Description

The current v2 commands archive starts with the JAN0702D loads, which comes from the v1 archive. That starting load is a bit arbitrary but stems from when iFOT load segments and timelines become mostly reliable.

This PR makes changes to support also ingesting all command loads from the the first available load of NOV2899D through JAN0702D. This commands in this time frame are referred to as pre2002 or pre-2002 in the code.

This requires a few things:

  • Create a command events file which is valid up through 2002:007.
  • Update code to allow ingesting pre-RLTT loads. This is done by inserting RLTT commands based on a standard rule for the timing.
  • Update cmds v1 to v2 migration script to include the loads from NOV2899 through (but not including) JAN0702D as a one-off step.
  • Functional testing

Fixes #242

Interface impacts

None, just makes pre-2002 commands available.

Testing

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

  • Validate that the post-JAN0702D commands from this PR match exactly the commands from Major refactor/improvement in command interrupt handling #248, which were themselves validated carefully against flight.
  • Validate the pre-JAN0702D commands against telemetry, adjusting the utils/pre2002/cmd_events.csv events as needed.

@taldcroft taldcroft changed the title Include all weekly command loads starting from NOV2899 WIP: Include all weekly command loads starting from NOV2899 Apr 5, 2023
@taldcroft
Copy link
Member Author

Probably not going to do this. The PR will still be around if it comes up again.

@taldcroft taldcroft closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State data missing from 2001:001 to 2003:001
1 participant