-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactor/improvement in command interrupt handling #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
18 tasks
jeanconn
reviewed
Aug 30, 2022
jeanconn
reviewed
Aug 30, 2022
jeanconn
reviewed
Aug 31, 2022
jeanconn
approved these changes
Aug 31, 2022
11 tasks
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements an idea that has been around for a long time to handle command interrupt processing in a more direct -way that more closely matches the OBC behavior. In particular:
A key implementation detail is the definition of "running commands". The basic outline of how this works is as follows.
CommandTable
objects corresponding to each approved command loadCommandTable
of commands for each Command Event.CommandTable
s (calledcmds_list
) by the date of the first command in each table.cmds_list
(for cmds in cmds_list:
)cmds
and collect them into a dict that captures the SCS numbers and end dates.cmds
in thecmds_list
and cut commands accordingly.cmds_list
tables and then sort into the standard backstop order.The key point to this change is that it simplifies the code logic and removes ad-hoc processing rules.
To do:
loads.csv
is no longer used as an input to processing.loads.csv
andloads.dat
output.Interface impacts
New END SCS and LOAD_EVENT commands are stored in the archive. No changes to actual spacecraft commands.
Testing
Unit tests
$SKA/data/kadi/cmds2.*
)Independent check of unit tests by Jean
Functional tests