Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up regex on file name and glob to work with CP data #308

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Oct 9, 2024

Description

Open up regex on file name and glob to work with Custom Process data.

This ends up coming up when Dale sends files for review for dark current checks etc, as the custom process files end up with axafm names or pcadm names or other variants. I don't see a downside to just opening these expressions and globs up a bit.

Interface impacts

Testing

Unit tests

  • Linux
jeanconn-fido> git rev-parse HEAD
55508a65cd334eba7dc8998d6b01a99e87319ad2
jeanconn-fido> pytest
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collected 108 items                                                                                                                                                                                               

mica/archive/tests/test_aca_dark_cal.py ..................                                                                                                                                                  [ 16%]
mica/archive/tests/test_aca_hdr3.py .                                                                                                                                                                       [ 17%]
mica/archive/tests/test_aca_l0.py ...                                                                                                                                                                       [ 20%]
mica/archive/tests/test_asp_l1.py .......                                                                                                                                                                   [ 26%]
mica/archive/tests/test_cda.py ..............................................                                                                                                                               [ 69%]
mica/archive/tests/test_obspar.py .                                                                                                                                                                         [ 70%]
mica/report/tests/test_write_report.py .                                                                                                                                                                    [ 71%]
mica/starcheck/tests/test_catalog_fetches.py ...............                                                                                                                                                [ 85%]
mica/stats/tests/test_acq_stats.py ...                                                                                                                                                                      [ 87%]
mica/stats/tests/test_guide_stats.py ....                                                                                                                                                                   [ 91%]
mica/vv/tests/test_vv.py .........                                                                                                                                                                          [100%]

========================================================================================= 108 passed in 522.09s (0:08:42)

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Functionally I tested this by successfully reading in the CP1107 data today.

Base automatically changed from fix-truncated-column to master October 24, 2024 18:52
@taldcroft taldcroft merged commit 9a3c5ab into master Oct 29, 2024
2 checks passed
@taldcroft taldcroft deleted the work-with-cp-data branch October 29, 2024 09:27
@javierggt javierggt mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants