Require minimum number of anchor stars for dyn bgd bonus #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
reviewed
Jun 20, 2022
| # situation where 4 stars are selected and 2 are faint bonus stars. In this case | ||
| # there would be only 2 anchor stars that ensure good tracking even without | ||
| # dyn bgd. | ||
| MIN_DYN_BGD_ANCHOR_STARS = 3 |
There was a problem hiding this comment.
This makes sense, but somewhat defeats having dyn_bgd_n_faint be option-driven. But if you go with n_guide - dyn_bgd_n_faint there are separate struggles with the corner cases. Maybe it could be n_guide - dyn_bgd_n_faint with a critical if n_guide != 5 and dyn_bgd_n_faint > 0.
jeanconn
approved these changes
Jul 6, 2022
This was referenced Jul 7, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding a temperature delta for the dynamic background bonus, require that at least 3 stars are so-called "anchor stars" with no bonus applied. These anchor stars are evaluated as for the legacy background with no bonus.
Interface impacts
None
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.