Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guide bright count check #175

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Update guide bright count check #175

merged 2 commits into from
Jul 7, 2022

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Jun 18, 2022 •
edited by taldcroft
Loading

Description

Update guide bright count check.

  1. This fixes a bug where fid/acq/mon were included in the check for a count of stars brighter than 6.1.
  2. This moves the bright count mag limit from 6.1 to 5.5 consistent with the star selection move from 5.8 to 5.2.

Interface impacts

Testing

Unit tests

  • Linux

Independent check of unit tests by @taldcroft :

  • Mac

Functional tests

Unit test updated to match the move of the bright count limit from 6.1 to 5.5.

@jeanconn jeanconn requested a review from taldcroft July 7, 2022 15:17
taldcroft
taldcroft approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran tests locally and they passed.

@jeanconn jeanconn merged commit 679d3cc into master Jul 7, 2022
@jeanconn jeanconn deleted the bright-count branch July 7, 2022 16:53
This was referenced Jul 7, 2022
Closed
Merged
@javierggt javierggt mentioned this pull request Aug 10, 2022
Merged
@javierggt javierggt mentioned this pull request Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanconn @taldcroft