Add a virtual destructor for BTreeDelete node to fix new-delete-type-mismatch #2127 #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2130 +/- ##
==========================================
- Coverage 75.32% 75.26% -0.07%
==========================================
Files 452 452
Lines 27357 27358 +1
==========================================
- Hits 20608 20591 -17
- Misses 6749 6767 +18
|
|
Let's try to fix the issue entirely. |
|
Maybe we can leave it open so that people can see the changes... |
|
Solved by #2287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2127. This is only a partial fix since there is now a
heap-use-after-freeerror, I will create a new issue for this.Root cause: The
deleteon this line is for a parentnodepointer, howevernodeis polymorphic and could be aninner_node(which has its own destructor).