Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deb file creation #2255

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Fix deb file creation #2255

merged 2 commits into from
Apr 5, 2022

Conversation

mmcgr
Copy link
Member

@mmcgr mmcgr commented Apr 5, 2022

Deb files are being created with incorrectly formatted information. While not important in general, it breaks some standard repository tooling. (The old, old format was also mildly incorrect but the errors were ignored.)

Note that the contact information in the deb file is changed from 'Patrick H.' to 'Bernhard Scholz [email protected]'. I'm assuming that's appropriate since it matches the changelog.

@mmcgr mmcgr requested a review from b-scholz April 5, 2022 03:26
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #2255 (67be7cc) into master (97d74ca) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2255      +/-   ##
==========================================
- Coverage   75.09%   75.09%   -0.01%     
==========================================
  Files         455      455              
  Lines       28443    28443              
==========================================
- Hits        21360    21359       -1     
- Misses       7083     7084       +1     
Impacted Files Coverage Δ
src/include/souffle/utility/ParallelUtil.h 75.96% <0.00%> (-0.78%) ⬇️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@b-scholz b-scholz merged commit 3efd902 into souffle-lang:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants