Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test: getopt_long returns an int #2264

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

quentin
Copy link
Member

@quentin quentin commented Apr 20, 2022

Reconciles the type of the variable c with the value returned by getopt_long() in the test getopt_long_test.cpp.

Relates to #2259, I cannot guarantee this change will fix the test issue found on Apple ARM M1, unfortunately I don't have access to a machine with this architecture and Github actions does not provide this platform.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #2264 (f9533e4) into master (7a15b74) will decrease coverage by 0.06%.
The diff coverage is 24.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2264      +/-   ##
==========================================
- Coverage   75.12%   75.06%   -0.07%     
==========================================
  Files         455      455              
  Lines       28465    28495      +30     
==========================================
+ Hits        21385    21390       +5     
- Misses       7080     7105      +25     
Impacted Files Coverage Δ
src/ast/utility/SipsMetric.h 30.00% <22.22%> (+10.00%) ⬆️
src/ast/utility/SipsMetric.cpp 51.23% <24.52%> (-2.73%) ⬇️
src/include/souffle/utility/ParallelUtil.h 75.19% <0.00%> (-1.56%) ⬇️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 82.92% <0.00%> (+1.62%) ⬆️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@b-scholz b-scholz merged commit ed75683 into souffle-lang:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants