Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not consider debug_delta relations as empty #2420

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

julienhenry
Copy link
Member

The RemoveEmptyRelations pass was removing debug_delta relations because they don't have rule and are not inputs.
This PR just fixes that to make sure debug_delta relations are not considered empty.

@julienhenry julienhenry requested a review from quentin June 29, 2023 15:11
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2420 (5cdb13f) into master (2914f7b) will increase coverage by 0.07%.
The diff coverage is 81.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2420      +/-   ##
==========================================
+ Coverage   77.75%   77.82%   +0.07%     
==========================================
  Files         474      479       +5     
  Lines       31164    31396     +232     
==========================================
+ Hits        24232    24435     +203     
- Misses       6932     6961      +29     
Impacted Files Coverage Δ
src/ast/analysis/typesystem/Type.cpp 47.37% <0.00%> (-0.47%) ⬇️
src/ast/analysis/typesystem/Type.h 50.00% <ø> (ø)
...c/ast/analysis/typesystem/TypeConstrainsAnalysis.h 100.00% <ø> (ø)
src/ast2ram/seminaive/ValueTranslator.h 100.00% <ø> (ø)
src/ast2ram/utility/TranslatorContext.h 100.00% <ø> (ø)
src/include/souffle/utility/SubProcess.h 55.00% <0.00%> (ø)
src/interpreter/Node.h 96.95% <ø> (ø)
src/ram/Variable.h 45.45% <45.45%> (ø)
src/ram/Assign.h 50.00% <50.00%> (ø)
src/parser/parser.yy 93.85% <58.33%> (-1.30%) ⬇️
... and 23 more

... and 5 files with indirect coverage changes

@quentin quentin merged commit 4a25402 into souffle-lang:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants