Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom indentation spacing support #29

Merged
merged 13 commits into from
Sep 13, 2021
Merged

Conversation

chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented Sep 7, 2021

Closes #18

Requires norad changes as of linebender/norad#148

We will define the default indentation as a single tab per level. This PR adds customization options for 1 - 4 space or tab char per level across glif and plist files.

TODO

  • add glif serialization format tests
  • add plist serialization format tests

@chrissimpkins chrissimpkins marked this pull request as ready for review September 10, 2021 05:10
@chrissimpkins
Copy link
Member Author

Implemented as of 96b569f

Needs additional plist file tests and then we should be GTG

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Sep 10, 2021

@madig I think that we are in good shape here. Custom indentation seems to be working across all UFO files. Thoughts about the approach?

@chrissimpkins chrissimpkins merged commit 8469af3 into main Sep 13, 2021
@chrissimpkins chrissimpkins deleted the indentation-spacing branch September 13, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom indentation space formatting in write files
1 participant