This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.5.x] fix: Fix Chrome stack overflow during highlighting #64074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the spread operator with large arrays can trigger a stack overflow in Chrome/V8. For example, see: - nodejs/node#16870 In a highlighting context, we can have 10k-100k occurrences in a file, so let's avoid using the spread operator. Fixes https://linear.app/sourcegraph/issue/GRAPH-772 ## Test plan Manually tested against sample file.  ## Changelog - Fixes a Chrome-specific stack overflow when highlighting large files. (cherry picked from commit 2644e24)
sourcegraph-release-bot
requested review from
varungandhi-src,
a team and
jdpleiness
and removed request for
a team
sourcegraph-release-bot
added
team/graph
varungandhi-src
approved these changes
Jul 25, 2024
|
FYI, we recently removed the branch protection rules that caused only the release team to be able to merge (see https://sourcegraph.slack.com/archives/C0EPTDE9L/p1720640223975069). Please feel free to merge this yourself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the spread operator with large arrays can trigger a
stack overflow in Chrome/V8. For example, see:
In a highlighting context, we can have 10k-100k occurrences
in a file, so let's avoid using the spread operator.
Fixes https://linear.app/sourcegraph/issue/GRAPH-772
Test plan
Manually tested against sample file.
Changelog
Backport 2644e24 from fix: Fix Chrome stack overflow during highlighting #64072