Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A ci rule that will ensure all build and dev deps are valid (not broken) #1077

Closed
shahzadlone opened this issue Feb 7, 2023 · 0 comments · Fixed by #1078
Closed

A ci rule that will ensure all build and dev deps are valid (not broken) #1077

shahzadlone opened this issue Feb 7, 2023 · 0 comments · Fixed by #1078
Assignees
@shahzadlone
Labels
ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality dependencies Related to dependencies
Milestone
DefraDB v0.5

Comments

@shahzadlone
Copy link
Member

Add a ci rule that will ensure all build and dev deps are working and not broken.

This has happened a few times now, and would be nice if we have a rule for this, this can be an optional rule before merging into develop as this can be broken by stuff not introduced by the pr.
@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality dependencies Related to dependencies labels Feb 7, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5 milestone Feb 7, 2023
@shahzadlone shahzadlone self-assigned this Feb 7, 2023
@shahzadlone shahzadlone mentioned this issue Feb 7, 2023
Merged
4 tasks
shahzadlone added a commit that referenced this issue Feb 7, 2023
@shahzadlone
ci: Add workflow to ensure deps build properly (#1078)
5591416 
- Resolves #1077
- Resolves #1075
- Resolves-Partially #1076 
- Updated to new PATv2 (in the secrets) and updated with the new PAT name `ONLY_DEFRADB_REPO_CI_PAT`.
- Add a new CI workflow to test our dependency-building steps are not broken (not required for PR to merge).
- Add the deploy script that was written for cloning defradb on the cloud infra.
- Added missing headers in workflow files.
shahzadlone added a commit that referenced this issue Apr 13, 2023
@shahzadlone
ci: Add workflow to ensure deps build properly (#1078)
deb65e7 
- Resolves #1077
- Resolves #1075
- Resolves-Partially #1076 
- Updated to new PATv2 (in the secrets) and updated with the new PAT name `ONLY_DEFRADB_REPO_CI_PAT`.
- Add a new CI workflow to test our dependency-building steps are not broken (not required for PR to merge).
- Add the deploy script that was written for cloning defradb on the cloud infra.
- Added missing headers in workflow files.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
ci: Add workflow to ensure deps build properly (sourcenetwork#1078)
24ba329 
- Resolves sourcenetwork#1077
- Resolves sourcenetwork#1075
- Resolves-Partially sourcenetwork#1076 
- Updated to new PATv2 (in the secrets) and updated with the new PAT name `ONLY_DEFRADB_REPO_CI_PAT`.
- Add a new CI workflow to test our dependency-building steps are not broken (not required for PR to merge).
- Add the deploy script that was written for cloning defradb on the cloud infra.
- Added missing headers in workflow files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality dependencies Related to dependencies
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging a pull request may close this issue.

ci: Add workflow to ensure deps build properly sourcenetwork/defradb
1 participant
@shahzadlone