fix: Support relationships where both fields have the same name #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
jsimnz
approved these changes
Jan 11, 2022
| @@ -195,7 +194,6 @@ func (p *Planner) makeTypeJoinOne(parent *selectNode, source planNode, subType * | |||
|
|
|||
| typeJoin.subTypeName = subTypeFieldDesc.Name | |||
| typeJoin.subTypeFieldName = subtypefieldname | |||
| typeJoin.rootName = desc.Name // @todo: Correctly handle getting sub/root names | |||
There was a problem hiding this comment.
you make a change to this in the named relationships branch as well. Will def need to be rebased, and re-sorted here
| for i, f := range r.fields { | ||
| if f == field { | ||
| if f == field && r.schemaTypes[i] == schemaType { |
There was a problem hiding this comment.
the key to this fix 👍. Not sure how I missed this originally :/.
There was a problem hiding this comment.
Is a bit of an edge case and easy to miss if wrestling with the main relationship stuff :)
|
Depends which between this branch and the |
1 task
Closed
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…cenetwork#109) * Remove unneeded explicit type declaration * Remove commented out code * Reduce field.type.name calls * Remove unused property * Support relationships between two fields of same name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
Technically two issues here I think:
On the one-many side: Relation.GetField was just returning the first with the same name, making the functionality dependent on golang's randomized map ordering.
On the many-one side: typeJoinMany was just using the schema name + id as the foreign key field name, causing the lookup to fail if the relationship was not named after the other schema.