Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for named relationships #108

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

AndrewSisley
Copy link
Contributor

@AndrewSisley AndrewSisley commented Jan 10, 2022

Closes #103

Allows for multiple relationships between the same two schemas.

  • Check/update tech-spec/query-spec post merge

@AndrewSisley AndrewSisley added feature New feature or request area/query Related to the query component area/schema Related to the schema system area/collections Related to the collections system labels Jan 10, 2022
@AndrewSisley AndrewSisley self-assigned this Jan 10, 2022
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty good! Only 2 random comments, but nothing structural. Just those minor things, and merge away. Excited to have this in.

query/graphql/planner/type_join.go Outdated Show resolved Hide resolved
query/graphql/schema/generate.go Show resolved Hide resolved
Redunant declarations results in warnings in VSC
Occured when relationship was not traversed correctly in query, might not be needed
@AndrewSisley AndrewSisley force-pushed the sisley/feat/I103-multiple-relationships branch from 6932fd2 to 1f211bf Compare January 11, 2022 13:18
@AndrewSisley AndrewSisley force-pushed the sisley/feat/I103-multiple-relationships branch from 1f211bf to fe85dad Compare January 11, 2022 13:29
@AndrewSisley AndrewSisley merged commit 4e89168 into develop Jan 11, 2022
@AndrewSisley AndrewSisley deleted the sisley/feat/I103-multiple-relationships branch January 11, 2022 13:32
@orpheuslummis orpheuslummis mentioned this pull request Jan 29, 2022
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
* Add info to relationship not found error

* Remove redunant type declarations

Redunant declarations results in warnings in VSC

* Check for nil iterator before closing

Occured when relationship was not traversed correctly in query, might not be needed

* Add support for multiple relationships between same collections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collections Related to the collections system area/query Related to the query component area/schema Related to the schema system feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow more than one relationship between two collections/named relationships
2 participants