fix: Handle errors generated during input object thunks #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
force-pushed
the
sisley/fix/I112-input-object-thunk-error-handling
branch
from
eab4b1a
to
7abc59d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #123 +/- ##
===========================================
- Coverage 63.86% 63.85% -0.02%
===========================================
Files 80 80
Lines 7328 7334 +6
===========================================
+ Hits 4680 4683 +3
- Misses 2163 2165 +2
- Partials 485 486 +1
|
5 tasks
jsimnz
reviewed
Jan 27, 2022
Is a hidden issue, AppendType is actually returning an error for many of our unit tests however it is being ignored
AndrewSisley
force-pushed
the
sisley/fix/I112-input-object-thunk-error-handling
branch
from
7abc59d
to
826791a
Compare
AndrewSisley
deleted the
sisley/fix/I112-input-object-thunk-error-handling
branch
Cheers :) |
Closed
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…k#123) * Generate Filter base args for all objects before resolving Is a hidden issue, AppendType is actually returning an error for many of our unit tests however it is being ignored * Handle errors raised in input object thunks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112
Also includes a fix for a hidden issue where errors were being silently generated during many of our tests but being ignored (see commit
Generate Filter base args for all objects before resolving). Note that fixing this issue removes any currently generateable errors from the current thunks, however I believe we should still have support for this lest we later introduce more hidden errors.Dependent on sourcenetwork/graphql-go#3
Todo: