Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commits input arg is call field, but the corresponding field is call fieldId #1452

Closed
AndrewSisley opened this issue May 4, 2023 · 2 comments · Fixed by #1460
Closed

commits input arg is call field, but the corresponding field is call fieldId #1452

AndrewSisley opened this issue May 4, 2023 · 2 comments · Fixed by #1460
Assignees
@AndrewSisley
Labels
area/query Related to the query component code quality Related to improving code quality
Milestone
DefraDB v0.5.1

Comments

@AndrewSisley
Copy link
Contributor

e.g.:

commits (field: "1") {
	fieldId
}

should be:

commits (fieldId: "1") {
	fieldId
}
@AndrewSisley AndrewSisley added area/query Related to the query component code quality Related to improving code quality labels May 4, 2023
@orpheuslummis
Copy link
Contributor

is there a consensus convention for the codebase on using Id vs ID ?

@AndrewSisley
Copy link
Contributor Author

is there a consensus convention for the codebase on using Id vs ID ?

I think we have spoken a few times about this, but I cant remember any agreement. We currently have both though, and that is not nice.

@AndrewSisley AndrewSisley self-assigned this May 5, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5.1 milestone May 5, 2023
@AndrewSisley AndrewSisley mentioned this issue May 5, 2023
Merged
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
fix: Rename commit field input arg to fieldId (sourcenetwork#1460)
e588f29 
## Relevant issue(s)

Resolves sourcenetwork#1452 

## Description

Renames commit `field` input arg to `fieldId`, to match the field
`fieldId`. Includes the explain output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/query Related to the query component code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging a pull request may close this issue.

fix: Rename commit field input arg to fieldId AndrewSisley/defradb
2 participants
@orpheuslummis @AndrewSisley