test: Convert explain order tests to new explain setup #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the order join tests from this file, will add them in a seperate file.
Partially converted because switched them to `ExpectedFullGraph` for now which keeps the original full graph, so when I change it in next commit the diff can be tracable.
the join refactor.
shahzadlone
added
area/testing
Codecov Report
@@ Coverage Diff @@
## develop #1478 +/- ##
===========================================
+ Coverage 72.18% 72.23% +0.04%
===========================================
Files 185 185
Lines 18226 18226
===========================================
+ Hits 13157 13166 +9
+ Misses 4029 4023 -6
+ Partials 1040 1037 -3 |
shahzadlone
force-pushed
the
test/refactor-order-explain-tests
branch
from
b3382e1
to
c5161e8
Compare
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…#1478) ## Relevant issue(s) - Part of sourcenetwork#953 - Resolves sourcenetwork#1477 ## Description Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot more detail on the entire plan. - This PR converts all the default order explain tests to the new explain setup. - Splits the order join tests into a separate file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Description
Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. #953 Has a lot more detail on the entire plan.