Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the explain tests to use the new explain setup #953

Closed
24 tasks done
shahzadlone opened this issue Nov 25, 2022 · 1 comment · Fixed by #1543
Closed
24 tasks done

Convert the explain tests to use the new explain setup #953

shahzadlone opened this issue Nov 25, 2022 · 1 comment · Fixed by #1543
Assignees
@shahzadlone
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Milestone
DefraDB v0.6

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Nov 25, 2022 •
edited
Loading

Description

Currently we have 3 types of testing frameworks:

  1. Old integration testing setup
  2. New explain setup, this was the setup we needed to convert all explain tests to from (1). (test: Add new setup for testing explain functionality #949)
  3. New integration testing setup based on actions. (refactor: Rework integration test framework #1089)
  4. After (3) was introduced, it is much more flexible, so the goal is to integrate (2) into (3) so we can use it for explain tests as well. Inorder to do (4) we need to do this ticket (Convert the explain tests to use the new explain setup #953) first (a) from below. The issue ticket for (4) is Integrate the new explain test setup into the new test action system #1243.

Situation

We are currently in the middle of the migrations between:
a. (1) -> (2) ... This is what this ticket is for (#953)
b. (1) -> (3)
c. After (4) is done do: (2) -> (4)

Default Explain Tests to convert:

NOTE: Must be done as part of (a) before we can do (4).

  • basic_test.go
  • invalid_type_arg_test.go
  • dagscan_test.go
  • create_test.go
  • update_test.go
  • delete_test.go
  • with_filter_key_test.go
  • with_filter_test.go
  • with_limit_test.go
  • with_order_test.go
  • top_with_average_test.go
  • top_with_count_test.go
  • top_with_sum_test.go
  • type_join_test.go
  • with_average_test.go
  • with_count_test.go
  • with_sum_test.go
  • group_test.go
  • group_with_average_test.go
  • group_with_dockey_test.go
  • group_with_filter_test.go
  • group_with_limit_test.go
  • group_with_order_test.go

Simple Explain tests to convert:

  • ### NOTE: Must be done as part of (a) before we can do (4).

Explain Explain tests to convert:

NOTE: the execute explain tests already use (3), convert them to (4) after (c).
@shahzadlone shahzadlone added area/testing Related to any test or testing suite code quality Related to improving code quality labels Nov 25, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.4 milestone Nov 25, 2022
@shahzadlone shahzadlone self-assigned this Nov 25, 2022
@shahzadlone shahzadlone mentioned this issue Nov 25, 2022
Merged
4 tasks
@shahzadlone
Copy link
Member Author

There is roughly around 8k lines of test code that needs to be converted and I am halfway there but I don't want to rush it and accidentally miss a test case that existed before. Will push this for v0.5

@shahzadlone shahzadlone modified the milestones: DefraDB v0.4, DefraDB v0.5 Dec 16, 2022
@shahzadlone shahzadlone mentioned this issue Dec 16, 2022
Closed
@shahzadlone shahzadlone changed the title Convert the explain tests to use the new explain setup [EPIC] Convert the explain tests to use the new explain setup Apr 20, 2023
@shahzadlone shahzadlone changed the title [EPIC] Convert the explain tests to use the new explain setup Convert the explain tests to use the new explain setup Apr 20, 2023
This was referenced Apr 20, 2023
Closed
Merged
shahzadlone added a commit that referenced this issue Apr 21, 2023
@shahzadlone
test: Convert filter explain tests to new explain setup (#1380)
855f6fe 
- Part of #953
- Resolves #1379
- Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. #953 Has a lot more detail on the entire plan.
- Removes example tests that we don't need any more, if there is anything in them documentation wise that a reviewer wants found helpful I can introduce a README.md upon request.
- Removes some tests that provide no value wrt to non-execution explain tests.
This was referenced Apr 27, 2023
Merged
Closed
Closed
shahzadlone added a commit that referenced this issue May 1, 2023
@shahzadlone
test: Convert mutation explain tests to new explain setup (#1416)
0e3801e 
-Resolves #1417

- Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. #953 Has a lot more detail on the entire plan.

- This PR converts all the default mutation explain tests to the new explain setup.

- Splits delete tests into two files one with error and without.
- Splits multi tests from single function into separate test functions (easier to maintain and debug). 
- Removes some tests that provide no value wrt to non-execution explain tests.
@shahzadlone shahzadlone mentioned this issue May 3, 2023
Merged
shahzadlone added a commit that referenced this issue May 3, 2023
@shahzadlone
test: Convert explain limit tests to new explain setup (#1446)
1f1d5ce 
## Relevant issue(s)
- Part of #953
- Resolves #1429

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action based setup. #953 Has a lot
more detail on the entire plan.

This PR converts all the default limit explain tests to the new explain
setup.

Splits limit tests into multiple files.
This was referenced May 10, 2023
Closed
Merged
Closed
Merged
Closed
Merged
Closed
Merged
shahzadlone added a commit that referenced this issue May 10, 2023
@shahzadlone
test: Convert explain top-level tests to new explain setup (#1480)
9fa6e81 
## Relevant issue(s)
- Part of #953
- Resolves #1479

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. #953 Has a lot
more detail on the entire plan.

- This PR converts all the default top-level explain tests.
This was referenced May 10, 2023
Closed
Closed
Closed
Merged
Merged
Merged
shahzadlone added a commit that referenced this issue May 11, 2023
@shahzadlone
test: Convert explain average tests to new explain setup (#1487)
2b72cc2 
## Relevant issue(s)
- Part of #953
- Resolves #1484

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. #953 Has a lot
more detail on the entire plan.

- This PR converts all the default explain average tests.
- Separates the average join tests into a new file.
shahzadlone added a commit that referenced this issue May 11, 2023
@shahzadlone
test: Convert explain sum tests to new explain setup (#1489)
864b3db 
## Relevant issue(s)
- Part of #953
- Resolves #1485

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. #953 Has a lot
more detail on the entire plan.

- This PR converts all the default explain sum tests.
- Splits sum join tests in a separate file.
shahzadlone added a commit that referenced this issue May 11, 2023
@shahzadlone
test: Convert explain count tests to new explain setup (#1488)
79af741 
## Relevant issue(s)
- Part of #953
- Resolves #1486 

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. #953 Has a lot
more detail on the entire plan.

- This PR converts all the default explain count tests.
- Splits count join tests in a separate file.
- Adds some new tests that were missed before.
This was referenced May 25, 2023
Closed
Merged
shahzadlone added a commit that referenced this issue May 26, 2023
@shahzadlone
test: Convert explain group tests to new explain setup (#1537)
3e212bc 
## Relevant issue(s)
- Part of #953
- Resolves #1536 

## Description
This PR is the last PR for default explain test conversions, this PR
converts the remaining group tests.

- This PR converts all the default explain group tests.
- Separates some tests into their group child select cases.
- Added a few tests where there was a test gap.
@shahzadlone shahzadlone mentioned this issue May 29, 2023
Merged
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert filter explain tests to new explain setup (sourcenetwor…
b62e2da 
…k#1380)

- Part of sourcenetwork#953
- Resolves sourcenetwork#1379
- Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot more detail on the entire plan.
- Removes example tests that we don't need any more, if there is anything in them documentation wise that a reviewer wants found helpful I can introduce a README.md upon request.
- Removes some tests that provide no value wrt to non-execution explain tests.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert mutation explain tests to new explain setup (sourcenetw…
f636a19 
…ork#1416)

-Resolves sourcenetwork#1417

- Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot more detail on the entire plan.

- This PR converts all the default mutation explain tests to the new explain setup.

- Splits delete tests into two files one with error and without.
- Splits multi tests from single function into separate test functions (easier to maintain and debug). 
- Removes some tests that provide no value wrt to non-execution explain tests.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain limit tests to new explain setup (sourcenetwork…
a937291 
…#1446)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1429

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

This PR converts all the default limit explain tests to the new explain
setup.

Splits limit tests into multiple files.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain dagscan tests to new explain setup (sourcenetwo…
f1d1931 
…rk#1474)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1473

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

- Fixes test names and some fixtures for the limit test.
- This PR converts all the default dagscan explain tests to the new
explain setup.
- Converts a wrong usage explain test case.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain join tests to new explain setup (sourcenetwork#…
4303c1a 
…1476)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1475

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action based testing setup. sourcenetwork#953
Has a lot more detail on the entire plan.

- Splits type join one tests into a separate file.
- Added some type join many tests into a separate file.
- This PR converts all the default typeJoin explain tests to the new
explain setup.
- Keeps the mixed test that use both type of joins in the original file.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain order tests to new explain setup (sourcenetwork…
808e52a 
…#1478)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1477

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

- This PR converts all the default order explain tests to the new
explain setup.
- Splits the order join tests into a separate file.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain top-level tests to new explain setup (sourcenet…
4aa86af 
…work#1480)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1479

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

- This PR converts all the default top-level explain tests.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain average tests to new explain setup (sourcenetwo…
9d7b7fb 
…rk#1487)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1484

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

- This PR converts all the default explain average tests.
- Separates the average join tests into a new file.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain sum tests to new explain setup (sourcenetwork#1489
81d9249 
)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1485

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

- This PR converts all the default explain sum tests.
- Splits sum join tests in a separate file.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain count tests to new explain setup (sourcenetwork…
495a4aa 
…#1488)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1486 

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

- This PR converts all the default explain count tests.
- Splits count join tests in a separate file.
- Adds some new tests that were missed before.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain group tests to new explain setup (sourcenetwork…
63135bc 
…#1537)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1536 

## Description
This PR is the last PR for default explain test conversions, this PR
converts the remaining group tests.

- This PR converts all the default explain group tests.
- Separates some tests into their group child select cases.
- Added a few tests where there was a test gap.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test(i): Convert simple explain test to new explain setup (sourcenetw…
cb75148 
…ork#1543)

## Relevant issue(s)
- Resolves sourcenetwork#953

## Description
This PR is the last PR that finishes all old explain test conversions to
the new explain setup. This PR converts the simple explain tests and
reorganizes some fixtures.

Note: After this PR is merged, this
(sourcenetwork#1243) can also be
resolved in a follow-up PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging a pull request may close this issue.

test(i): Convert simple explain test to new explain setup shahzadlone/defradb
1 participant
@shahzadlone