Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Convert explain average tests to new explain setup #1487

Merged

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Description

Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action-based setup. #953 Has a lot more detail on the entire plan.

  • This PR converts all the default explain average tests.
  • Separates the average join tests into a new file.

@shahzadlone shahzadlone added area/testing Related to any test or testing suite code quality Related to improving code quality labels May 10, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5.1 milestone May 10, 2023
@shahzadlone shahzadlone requested a review from a team May 10, 2023 19:24
@shahzadlone shahzadlone self-assigned this May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #1487 (090d220) into develop (54ed5b5) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1487      +/-   ##
===========================================
+ Coverage    72.13%   72.21%   +0.08%     
===========================================
  Files          185      185              
  Lines        18239    18239              
===========================================
+ Hits         13156    13172      +16     
+ Misses        4040     4029      -11     
+ Partials      1043     1038       -5     

see 5 files with indirect coverage changes

@shahzadlone shahzadlone force-pushed the test/refactor-avg-explain-tests branch from d0a8f99 to 090d220 Compare May 10, 2023 23:42
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone merged commit 2b72cc2 into sourcenetwork:develop May 11, 2023
@shahzadlone shahzadlone deleted the test/refactor-avg-explain-tests branch May 11, 2023 07:12
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
…rk#1487)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1484

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

- This PR converts all the default explain average tests.
- Separates the average join tests into a new file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert default average explain tests to new explain setup.
2 participants