Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete RPC API #1507

Closed
orpheuslummis opened this issue May 16, 2023 · 0 comments · Fixed by #1839
Closed

Complete RPC API #1507

orpheuslummis opened this issue May 16, 2023 · 0 comments · Fixed by #1839
Assignees
@nasdf
Labels
area/api Related to the external API component
Milestone
DefraDB v0.8

Comments

@orpheuslummis
Copy link
Contributor

orpheuslummis commented May 16, 2023 •
edited
Loading

Complete the RPC API by introducing something like the following methods:

    rpc Ping(PingRequest) returns (PingReply) {}
    rpc PeerID (PeerIDRequest) returns (PeerIDReply) {}
    rpc SchemaLoad(SchemaLoadRequest) returns (SchemaLoadReply) {}
    rpc SchemaPatch(SchemaPatchRequest) returns (SchemaPatchReply) {}
    rpc GraphQL(GraphQLRequest) returns (GraphQLReply) {}

Part of #1472
Ideally would be after / depend-on #1063
@orpheuslummis orpheuslummis added the area/api Related to the external API component label May 16, 2023
@orpheuslummis orpheuslummis added this to the DefraDB v0.6 milestone May 16, 2023
@fredcarle fredcarle modified the milestones: DefraDB v0.6, DefraDB v0.7 Jul 4, 2023
This was referenced Aug 28, 2023
Merged
Merged
@jsimnz jsimnz modified the milestones: DefraDB v0.7, DefraDB v0.8 Sep 18, 2023
@nasdf nasdf closed this as completed in 4c3df48 Oct 2, 2023
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@nasdf
refactor: CLI client interface (sourcenetwork#1839)
c006fed 
## Relevant issue(s)

Closes sourcenetwork#1472
Closes sourcenetwork#1507
Closes sourcenetwork#1860 

## Description

This is a follow up to sourcenetwork#1776

This PR adds a CLI implementation that implements the client.DB
interface and runs through the existing integration test suite.

- [x] Merge existing server config code
- [x] Refactor CLI to use new HTTP client
- [x] Remove `net/api` package
- [x] Remove `api/http` package
- [x] Lens tests are timing out in CI: fixed sourcenetwork#1862
- [x] Code coverage is incorrectly reporting: fixed sourcenetwork#1861
- [x] Flaky test causing failures: fixed sourcenetwork#1912

Renamed Commands:
- `peerid` to `client peer info`
- `client p2pcollection` to `client p2p collection`
- `client replicator` to `client p2p replicator`
- `client schema list` to `client collection describe`

Removed Commands:
- `block get`
- `ping`
- `rpc`

Added Commands:
- `client collection create`
- `client collection delete`
- `client collection get`
- `client collection keys`
- `client collection update`
- `client tx create`
- `client tx discard`
- `client tx commit`
- `client schema migration up`
- `client schema migration down`
- `client schema migration reload`

**Notes for reviewers**:
- `.github` changes are merged from sourcenetwork#1871
- `Makefile` most of these changes are also from sourcenetwork#1871
- `docs/cli` ignore these changes, it will be updated next release
- sorry for all of the merge commits, I am working on learning rebase
flow

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

`make test`

Specify the platform(s) on which this was tested:
- MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasdf nasdf

Labels
area/api Related to the external API component
Projects
None yet
Milestone
DefraDB v0.8
Development

Successfully merging a pull request may close this issue.

refactor: CLI client interface nasdf/defradb
4 participants
@orpheuslummis @nasdf @jsimnz @fredcarle