Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove txn param from Fetcher.Start #1623

Closed
AndrewSisley opened this issue Jul 11, 2023 · 0 comments · Fixed by #1635
Closed

Remove txn param from Fetcher.Start #1623

AndrewSisley opened this issue Jul 11, 2023 · 0 comments · Fixed by #1635
Assignees
@AndrewSisley
Labels
area/db-system Related to the core system related components of the DB code quality Related to improving code quality refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
DefraDB v0.6

Comments

@AndrewSisley
Copy link
Contributor

As of #1564 it should be taken from the Init call.
@AndrewSisley AndrewSisley added area/db-system Related to the core system related components of the DB refactor This issue specific to or requires *notable* refactoring of existing codebases and components code quality Related to improving code quality labels Jul 11, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.6 milestone Jul 11, 2023
@AndrewSisley AndrewSisley mentioned this issue Jul 11, 2023
Merged
10 tasks
@AndrewSisley AndrewSisley self-assigned this Jul 13, 2023
@AndrewSisley AndrewSisley mentioned this issue Jul 13, 2023
Merged
AndrewSisley added a commit that referenced this issue Jul 17, 2023
@AndrewSisley
refactor: Remove redundant txn param from fetcher start (#1635)
8197795 
## Relevant issue(s)

Resolves #1623

## Description

Removes the redundant txn param from fetcher start as it is always the
same value as fetcher.Init
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
refactor: Remove redundant txn param from fetcher start (sourcenetwor…
5edc205 
…k#1635)

## Relevant issue(s)

Resolves sourcenetwork#1623

## Description

Removes the redundant txn param from fetcher start as it is always the
same value as fetcher.Init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/db-system Related to the core system related components of the DB code quality Related to improving code quality refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging a pull request may close this issue.

refactor: Remove redundant txn param from fetcher start AndrewSisley/defradb
1 participant
@AndrewSisley