Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup-Import cannot handle self referencing documents #1697

Closed
AndrewSisley opened this issue Jul 24, 2023 · 0 comments · Fixed by #1701
Closed

Backup-Import cannot handle self referencing documents #1697

AndrewSisley opened this issue Jul 24, 2023 · 0 comments · Fixed by #1701
Assignees
@fredcarle
Labels
area/db-system Related to the core system related components of the DB bug Something isn't working
Milestone
DefraDB v0.6

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Jul 24, 2023 •
edited
Loading

As documented by TestBackupSelfRefImport_SelfReferencing_NoError and TestBackupSelfRefImport_SplitPrimaryRelationWithSecondCollection_NoError.

Whilst it is very difficult to achieve by import alone due to difficulties in generating the relation-id, this issue does mean that an export of such a document cannot be imported correctly.
@AndrewSisley AndrewSisley added bug Something isn't working area/db-system Related to the core system related components of the DB labels Jul 24, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.6 milestone Jul 24, 2023
@AndrewSisley AndrewSisley mentioned this issue Jul 24, 2023
Merged
@fredcarle fredcarle mentioned this issue Jul 24, 2023
Merged
4 tasks
AndrewSisley added a commit that referenced this issue Jul 24, 2023
@AndrewSisley
test: Expand backup integration tests (#1699)
f4bc169 
## Relevant issue(s)

Resolves #1696 

## Description

Expands the backup integration tests, and fixes an invalid schema
declaration.

Documents #1697

I went over the CLI tests too, but found no gaps.
@fredcarle fredcarle self-assigned this Jul 25, 2023
fredcarle added a commit that referenced this issue Jul 25, 2023
@fredcarle @shahzadlone
fix(i): Add self reference import handling (#1701)
cb94add 
## Relevant issue(s)

Resolves #1697 

## Description

This PR add the capability to handle self referencing docs on import.

Co-authored-by: Shahzad Lone <[email protected]>
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
test: Expand backup integration tests (sourcenetwork#1699)
f33999f 
## Relevant issue(s)

Resolves sourcenetwork#1696 

## Description

Expands the backup integration tests, and fixes an invalid schema
declaration.

Documents sourcenetwork#1697

I went over the CLI tests too, but found no gaps.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle @shahzadlone
fix(i): Add self reference import handling (sourcenetwork#1701)
86522c2 
## Relevant issue(s)

Resolves sourcenetwork#1697 

## Description

This PR add the capability to handle self referencing docs on import.

Co-authored-by: Shahzad Lone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/db-system Related to the core system related components of the DB bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging a pull request may close this issue.

fix(i): Add self reference import handling sourcenetwork/defradb
2 participants
@fredcarle @AndrewSisley