Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field alias does not exist in some cases for update of one-one #1703

Closed
AndrewSisley opened this issue Jul 24, 2023 · 0 comments · Fixed by #2161
Closed

Field alias does not exist in some cases for update of one-one #1703

AndrewSisley opened this issue Jul 24, 2023 · 0 comments · Fixed by #2161
Assignees
@fredcarle
Labels
area/collections Related to the collections system bug Something isn't working
Milestone
DefraDB v0.9

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Jul 24, 2023 •
edited
Loading

Documented by tests:

  • TestMutationUpdateOneToMany_InvalidAliasRelationNameToLinkFromManySide_GQL
  • TestMutationUpdateOneToMany_InvalidAliasRelationNameToLinkFromManySide_Collection
  • TestMutationUpdateOneToMany_AliasRelationNameToLinkFromManySideWithWrongField_Error
  • TestMutationUpdateOneToMany_AliasRelationNameToLinkFromManySide
  • TestMutationUpdateOneToOne_AliasRelationNameToLinkFromPrimarySide
  • TestMutationUpdateOneToOne_AliasRelationNameToLinkFromSecondarySide
  • TestMutationUpdateOneToOne_AliasWithInvalidLengthRelationIDToLink_Error
  • TestMutationUpdateOneToOne_InvalidAliasRelationNameToLinkFromSecondarySide_Error
@AndrewSisley AndrewSisley added bug Something isn't working area/collections Related to the collections system labels Jul 24, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.6 milestone Jul 24, 2023
@fredcarle fredcarle modified the milestones: DefraDB v0.6, DefraDB v0.7, DefraDB v0.8 Jul 31, 2023
@AndrewSisley AndrewSisley mentioned this issue Sep 7, 2023
Merged
AndrewSisley added a commit that referenced this issue Sep 14, 2023
@AndrewSisley
test(i): Update mut. tests to make use of mut. system (#1853)
c70676e 
## Relevant issue(s)

Resolves #1851

## Description

Updates the mutation tests to make use of mutation system.

A handful of collection based tests still exist, as they test stuff that
does not yet have support in the new mutation test system (filter,
UpdateWithKey(s)). These should be moved later when such support is
added.

Similarly, the new mutation system does not yet support txns, so the gql
request based txn tests remain as gql tests for now.

#1703 Was linked up to
tests in this PR, and
#1852 and
#1854 were discovered.
Fixing them is out of scope here.

Update: It does now fix a bug in the http client collection.Create[Many]
functions, as it was easier to fix than to open a ticket.
@AndrewSisley AndrewSisley removed this from the DefraDB v0.8 milestone Sep 15, 2023
@fredcarle fredcarle mentioned this issue Jan 4, 2024
Merged
4 tasks
@fredcarle fredcarle added this to the DefraDB v0.9 milestone Jan 4, 2024
@fredcarle fredcarle self-assigned this Jan 4, 2024
fredcarle added a commit that referenced this issue Jan 5, 2024
@fredcarle
refactor: Add strong typing to document creation (#2161)
0c1c4fe 
## Relevant issue(s)

Resolves #935 
Resolves #1703 

## Description

This PR adds strong document typing to document creation by using the
field descriptions to determine Go types. Datetime is now properly
supported and formatting is enforced.

Note that a lot of docIDs have changed as a result of this refactor.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Jan 22, 2024
@fredcarle @shahzadlone
refactor: Add strong typing to document creation (sourcenetwork#2161)
0316bc8 
## Relevant issue(s)

Resolves sourcenetwork#935 
Resolves sourcenetwork#1703 

## Description

This PR adds strong document typing to document creation by using the
field descriptions to determine Go types. Datetime is now properly
supported and formatting is enforced.

Note that a lot of docIDs have changed as a result of this refactor.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
test(i): Update mut. tests to make use of mut. system (sourcenetwork#…
9524a41 
…1853)

## Relevant issue(s)

Resolves sourcenetwork#1851

## Description

Updates the mutation tests to make use of mutation system.

A handful of collection based tests still exist, as they test stuff that
does not yet have support in the new mutation test system (filter,
UpdateWithKey(s)). These should be moved later when such support is
added.

Similarly, the new mutation system does not yet support txns, so the gql
request based txn tests remain as gql tests for now.

sourcenetwork#1703 Was linked up to
tests in this PR, and
sourcenetwork#1852 and
sourcenetwork#1854 were discovered.
Fixing them is out of scope here.

Update: It does now fix a bug in the http client collection.Create[Many]
functions, as it was easier to fix than to open a ticket.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
refactor: Add strong typing to document creation (sourcenetwork#2161)
e580868 
## Relevant issue(s)

Resolves sourcenetwork#935 
Resolves sourcenetwork#1703 

## Description

This PR adds strong document typing to document creation by using the
field descriptions to determine Go types. Datetime is now properly
supported and formatting is enforced.

Note that a lot of docIDs have changed as a result of this refactor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/collections Related to the collections system bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.9
Development

Successfully merging a pull request may close this issue.

refactor: Add strong typing to document creation fredcarle/defradb
2 participants
@fredcarle @AndrewSisley