chore: Update Badger version to v4 #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
added
area/datastore
Codecov ReportPatch and project coverage have no change.
@@ Coverage Diff @@
## develop #1740 +/- ##
===========================================
- Coverage 75.42% 75.42% -0.00%
===========================================
Files 208 208
Lines 21801 21801
===========================================
- Hits 16443 16442 -1
Misses 4210 4210
- Partials 1148 1149 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
reviewed
Aug 1, 2023
|
question: Has the fork been reviewed? |
Initial review has been done and it's not going to be the way to fix this but the badger team is also looking into it. Hopefully we get a proper fix before the end of this cycle. |
AndrewSisley
requested changes
Aug 1, 2023
fredcarle
force-pushed
the
fredcarle/fix/1702-update-badger-version
branch
from
07b60c7
to
8c50398
Compare
AndrewSisley
approved these changes
Aug 1, 2023
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1702 ## Description This PR updates the Badger version to v4. It includes a temporary fix to our badger `os.Exit` issue that is costing us time when managing PRs. This should be reverted or properly fixed before releasing v0.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1702
Description
This PR updates the Badger version to v4.
It includes a temporary fix to our badger
os.Exitissue that is costing us time when managing PRs. This should be reverted or properly fixed before releasing v0.7.Tasks
How has this been tested?
multiple runs of
env DEFRA_DETECT_DATABASE_CHANGES=true gotestsum -- ./tests/integration/query/one_to_many_to_one -shuffle=on -p 1Specify the platform(s) on which this was tested: