test(i): Update mut. tests to make use of mut. system #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/testing
AndrewSisley
changed the title
AndrewSisley
force-pushed
the
1851-mutation-tests
branch
from
6662c9b
to
ad116a2
Compare
Codecov ReportPatch coverage has no change and project coverage change:
@@ Coverage Diff @@
## develop #1853 +/- ##
===========================================
- Coverage 70.37% 70.26% -0.11%
===========================================
Files 232 232
Lines 24180 24192 +12
===========================================
- Hits 17016 16998 -18
- Misses 6003 6029 +26
- Partials 1161 1165 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
force-pushed
the
1851-mutation-tests
branch
2 times, most recently
from
c64d1f5
to
efde22c
Compare
shahzadlone
reviewed
Sep 8, 2023
tests/integration/mutation/update/field_kinds/one_to_many/with_alias_test.go
Show resolved
Hide resolved
shahzadlone
reviewed
Sep 8, 2023
tests/integration/mutation/update/field_kinds/one_to_many/with_alias_test.go
Show resolved
Hide resolved
shahzadlone
approved these changes
Sep 14, 2023
Only visually, the mutation queries are still executed by the tests. That loss of visibility is a cost that I am willing to pay for the increased coverage. |
AndrewSisley
force-pushed
the
1851-mutation-tests
branch
8 times, most recently
from
b859dc7
to
423decf
Compare
- TestMutationCreateOneToMany_AliasedRelationNamToLinkFromSingleSide_NoIDFieldError was removed as it is already tested. The first create has no impact on the outcome of the test. - TestMutationCreateOneToMany_RelationIDToLinkFromSingleSide_NoIDFieldError was removed for the same reasons.
These tests now already exist in the mutation directory
These tests now already exist in the mutation directory
This test now already exist in the mutation directory
AndrewSisley
force-pushed
the
1851-mutation-tests
branch
from
423decf
to
e7242e1
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…1853) ## Relevant issue(s) Resolves sourcenetwork#1851 ## Description Updates the mutation tests to make use of mutation system. A handful of collection based tests still exist, as they test stuff that does not yet have support in the new mutation test system (filter, UpdateWithKey(s)). These should be moved later when such support is added. Similarly, the new mutation system does not yet support txns, so the gql request based txn tests remain as gql tests for now. sourcenetwork#1703 Was linked up to tests in this PR, and sourcenetwork#1852 and sourcenetwork#1854 were discovered. Fixing them is out of scope here. Update: It does now fix a bug in the http client collection.Create[Many] functions, as it was easier to fix than to open a ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1851
Description
Updates the mutation tests to make use of mutation system.
A handful of collection based tests still exist, as they test stuff that does not yet have support in the new mutation test system (filter, UpdateWithKey(s)). These should be moved later when such support is added.
Similarly, the new mutation system does not yet support txns, so the gql request based txn tests remain as gql tests for now.
#1703 Was linked up to tests in this PR, and #1852 and #1854 were discovered. Fixing them is out of scope here.
Update: It does now fix a bug in the http client collection.Create[Many] functions, as it was easier to fix than to open a ticket.
Recommend reviewing commit by commit, nothing to fancy is going on, but it might make stuff more obvious.