Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FieldDescription.ID from Schema #2334

Closed
AndrewSisley opened this issue Feb 20, 2024 · 0 comments · Fixed by #2336
Closed

Remove FieldDescription.ID from Schema #2334

AndrewSisley opened this issue Feb 20, 2024 · 0 comments · Fixed by #2336
Assignees
@AndrewSisley
Labels
area/schema Related to the schema system bug Something isn't working feature New feature or request
Milestone
DefraDB v0.10

Comments

@AndrewSisley
Copy link
Contributor

At the moment schema branching doesn't really work, due to #2333.

We also we to move local field description stuff off the schema and on to the collection long term (so it's location makes sense, and doesn't impact the global schema).

Move FieldDescription.ID on to something on the CollectionDescription. Do so whilst keeping in mind that other stuff (such as (perhaps) RelationName, and secondary relation fields).
@AndrewSisley AndrewSisley added bug Something isn't working feature New feature or request area/schema Related to the schema system labels Feb 20, 2024
@AndrewSisley AndrewSisley mentioned this issue Feb 20, 2024
Closed
@AndrewSisley AndrewSisley added this to the DefraDB v0.10 milestone Feb 20, 2024
@AndrewSisley AndrewSisley self-assigned this Feb 20, 2024
This was referenced Feb 20, 2024
Open
Merged
AndrewSisley added a commit that referenced this issue Feb 28, 2024
@AndrewSisley
fix: Move field id off of schema (#2336)
db75564 
## Relevant issue(s)

Resolves #2334

## Description

Moves field id off of schema and onto collection.

It is now a local property and does not need to be the same across
multiple nodes. The new `Fields` property on `CollectionDescription`
will be where other local field stuff is move too from the schema
(relation_name, descriptions, secondary relation fields).

This change is a prerequisite of allowing fields to be deleted and
schema branching (see
#2333 for more info on
that if currious)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/schema Related to the schema system bug Something isn't working feature New feature or request
Projects
None yet
Milestone
DefraDB v0.10
Development

Successfully merging a pull request may close this issue.

fix: Move field id off of schema AndrewSisley/defradb
1 participant
@AndrewSisley