Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens runtime db.Option #2496

Closed
nasdf opened this issue Apr 5, 2024 · 0 comments · Fixed by #2497
Closed

Lens runtime db.Option #2496

nasdf opened this issue Apr 5, 2024 · 0 comments · Fixed by #2497
Assignees
Labels
feature New feature or request
Milestone

Comments

@nasdf
Copy link
Member

nasdf commented Apr 5, 2024

Allow the user to specify a custom lens runtime for a db instance.

@nasdf nasdf added the feature New feature or request label Apr 5, 2024
@nasdf nasdf mentioned this issue Apr 5, 2024
4 tasks
@nasdf nasdf self-assigned this Apr 5, 2024
@nasdf nasdf added this to the DefraDB v0.11 milestone Apr 5, 2024
nasdf added a commit that referenced this issue Apr 8, 2024
## Relevant issue(s)

Resolves #2496 

## Description

This PR adds a lens runtime option. It also includes some cleanup and
additional tests.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

`make test`

Specify the platform(s) on which this was tested:
- MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant