Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand documentation on CreatePredefinedDocs test action #2600

Closed
AndrewSisley opened this issue May 8, 2024 · 1 comment
Closed

Expand documentation on CreatePredefinedDocs test action #2600

AndrewSisley opened this issue May 8, 2024 · 1 comment
Assignees
@islamaliev
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Milestone
DefraDB v0.12

Comments

@AndrewSisley
Copy link
Contributor

There is a lot of magic that goes on in this action, and it is not documented on the action struct.

There is a very good readme here: https://github.com/sourcenetwork/defradb/blob/develop/tests/predefined/README.md

I think a two line summary on the CreatePredefinedDocs with a link to the readme would be very handy.
@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite code quality Related to improving code quality labels May 8, 2024
@AndrewSisley AndrewSisley mentioned this issue May 8, 2024
Merged
islamaliev added a commit that referenced this issue May 8, 2024
@islamaliev
fix: Remove limit for fetching secondary docs (#2594)
ed3550a 
## Relevant issue(s)

Resolves #2590 and #2600

## Description

Make join fetch all secondary docs of a fetched-by-index primary doc.
@islamaliev islamaliev self-assigned this May 8, 2024
@islamaliev islamaliev added this to the DefraDB v0.12 milestone May 8, 2024
@islamaliev
Copy link
Contributor

resolved within #2594

shahzadlone pushed a commit that referenced this issue May 14, 2024
@islamaliev @shahzadlone
fix: Remove limit for fetching secondary docs (#2594)
73ad077 
## Relevant issue(s)

Resolves #2590 and #2600

## Description

Make join fetch all secondary docs of a fetched-by-index primary doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@islamaliev islamaliev

Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.12
Development

No branches or pull requests
2 participants
@islamaliev @AndrewSisley