Providing invalid --keyring-backend value not validated and defaults to file without notifying user
#2759
Comments
AndrewSisley
added
bug
nasdf
added a commit
that referenced
this issue
Jun 27, 2024
## Relevant issue(s) Resolves #2759 Resolves #2758 Resolves #2757 ## Description This PR adds more logs to the keyring to improve the user experience. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? - unit test Specify the platform(s) on which this was tested: - MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, executing
defradb keyring import bar efcc38b57ccb9ddba3cf85a856acaeb28bbe7360fc0fe37630b3e91ff0bca86c --keyring-backend fdggsfaprompts for password and then completes without outputting anything (#2758).The imported key is then accessible via
defradb keyring export bar(using thefilebackend).The text was updated successfully, but these errors were encountered: