Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update ioutil package to io / os packages. #376

Merged
merged 1 commit into from
Apr 26, 2022
Merged

chore: Update ioutil package to io / os packages. #376

merged 1 commit into from
Apr 26, 2022

Conversation

shahzadlone
Copy link
Member

Resolves #375

@shahzadlone shahzadlone added the code quality Related to improving code quality label Apr 26, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone Apr 26, 2022
@shahzadlone shahzadlone self-assigned this Apr 26, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 93 Benchmarks were ✅ Better.
  • 20 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4297ms ± 0%250ms ± 0%−15.71%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-412.0ms ± 0%11.8ms ± 0%−1.50%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.10s ± 0%1.05s ± 0%−4.38%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-447.9ms ± 0%46.5ms ± 0%−3.07%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4472ms ± 0%451ms ± 0%−4.46%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.94s ± 0%4.67s ± 0%−5.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4382µs ± 0%330µs ± 0%−13.46%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.18ms ± 0%3.80ms ± 0%−8.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-441.4ms ± 0%39.5ms ± 0%−4.44%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4396µs ± 0%363µs ± 0%−8.42%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.10ms ± 0%3.77ms ± 0%−8.13%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4308µs ± 0%282µs ± 0%−8.65%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.93ms ± 0%1.85ms ± 0%−4.16%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.9ms ± 0%24.3ms ± 0%−2.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4264µs ± 0%254µs ± 0%−3.59%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.95ms ± 0%1.88ms ± 0%−3.52%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.44ms ± 0%1.28ms ± 0%−11.19%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-410.2ms ± 0%9.8ms ± 0%−3.95%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4571µs ± 0%478µs ± 0%−16.30%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.56ms ± 0%1.38ms ± 0%−11.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.2ms ± 0%10.2ms ± 0%−0.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4517µs ± 0%463µs ± 0%−10.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4783µs ± 0%720µs ± 0%−8.05%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4336µs ± 0%293µs ± 0%−12.89%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4346µs ± 0%286µs ± 0%−17.32%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4283µs ± 0%279µs ± 0%−1.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4469µs ± 0%465µs ± 0%−0.99%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.58ms ± 0%1.50ms ± 0%−4.86%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.4ms ± 0%12.4ms ± 0%−0.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-416.4µs ± 0%14.7µs ± 0%−10.84%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-417.6µs ± 0%17.1µs ± 0%−2.83%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-418.5µs ± 0%15.9µs ± 0%−14.22%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-422.0µs ± 0%20.1µs ± 0%−8.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4157µs ± 0%125µs ± 0%−20.75%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4165µs ± 0%157µs ± 0%−4.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4169µs ± 0%155µs ± 0%−8.40%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4173µs ± 0%169µs ± 0%−2.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4224µs ± 0%196µs ± 0%−12.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-417.3µs ± 0%16.4µs ± 0%−5.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.4µs ± 0%16.8µs ± 0%−3.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-418.6µs ± 0%18.3µs ± 0%−1.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-421.5µs ± 0%20.9µs ± 0%−2.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-430.2µs ± 0%25.6µs ± 0%−15.37%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4165µs ± 0%161µs ± 0%−2.07%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4174µs ± 0%154µs ± 0%−11.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4181µs ± 0%164µs ± 0%−9.63%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4191µs ± 0%174µs ± 0%−8.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4226µs ± 0%206µs ± 0%−9.02%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-453.9µs ± 0%50.3µs ± 0%−6.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-453.8µs ± 0%50.9µs ± 0%−5.47%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-470.4µs ± 0%70.0µs ± 0%−0.63%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4402µs ± 0%396µs ± 0%−1.56%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4416µs ± 0%405µs ± 0%−2.65%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4568µs ± 0%502µs ± 0%−11.53%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-449.9µs ± 0%49.3µs ± 0%−1.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-462.5µs ± 0%59.9µs ± 0%−4.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-475.5µs ± 0%74.3µs ± 0%−1.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4461µs ± 0%409µs ± 0%−11.37%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4525µs ± 0%432µs ± 0%−17.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4592µs ± 0%516µs ± 0%−12.85%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4139µs ± 0%121µs ± 0%−12.91%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4138µs ± 0%132µs ± 0%−4.69%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4139µs ± 0%125µs ± 0%−10.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4146µs ± 0%139µs ± 0%−5.19%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4160µs ± 0%151µs ± 0%−5.50%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.29ms ± 0%1.23ms ± 0%−4.53%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.39ms ± 0%1.25ms ± 0%−9.91%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.29ms ± 0%1.26ms ± 0%−2.80%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.37ms ± 0%1.28ms ± 0%−6.73%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.56ms ± 0%1.40ms ± 0%−10.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4135µs ± 0%113µs ± 0%−16.11%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4131µs ± 0%120µs ± 0%−8.19%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4134µs ± 0%132µs ± 0%−1.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.24ms ± 0%1.23ms ± 0%−1.17%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.43ms ± 0%1.28ms ± 0%−10.50%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.45ms ± 0%1.31ms ± 0%−9.35%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.63ms ± 0%1.43ms ± 0%−12.00%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-414.7µs ± 0%8.7µs ± 0%−40.98%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-412.0µs ± 0%9.1µs ± 0%−23.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.7µs ± 0%10.4µs ± 0%−2.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-416.4µs ± 0%12.0µs ± 0%−26.70%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-419.1µs ± 0%17.1µs ± 0%−10.73%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4132µs ± 0%129µs ± 0%−2.82%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4182µs ± 0%164µs ± 0%−9.70%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4130µs ± 0%129µs ± 0%−1.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4132µs ± 0%131µs ± 0%−0.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4144µs ± 0%122µs ± 0%−14.86%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4141µs ± 0%125µs ± 0%−11.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4136µs ± 0%128µs ± 0%−5.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.27ms ± 0%1.17ms ± 0%−7.53%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.27ms ± 0%1.20ms ± 0%−5.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.40ms ± 0%1.24ms ± 0%−11.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.33ms ± 0%1.29ms ± 0%−2.48%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_Create_Sync_0_100-4114ms ± 0%115ms ± 0%+0.50%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4501µs ± 0%543µs ± 0%+8.46%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4440µs ± 0%486µs ± 0%+10.54%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4700µs ± 0%712µs ± 0%+1.81%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4642µs ± 0%643µs ± 0%+0.17%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-459.7µs ± 0%60.5µs ± 0%+1.41%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-460.4µs ± 0%60.8µs ± 0%+0.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4386µs ± 0%432µs ± 0%+11.95%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4439µs ± 0%441µs ± 0%+0.48%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-450.9µs ± 0%60.5µs ± 0%+18.95%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-455.7µs ± 0%59.6µs ± 0%+7.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4388µs ± 0%415µs ± 0%+6.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4404µs ± 0%437µs ± 0%+8.24%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4130µs ± 0%134µs ± 0%+3.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4145µs ± 0%154µs ± 0%+6.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.32ms ± 0%1.33ms ± 0%+0.72%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4114µs ± 0%116µs ± 0%+1.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4113µs ± 0%131µs ± 0%+15.95%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4117µs ± 0%139µs ± 0%+18.78%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.24ms ± 0%1.27ms ± 0%+2.07%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.4ms ± 0%11.1ms ± 0%−2.92%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4297ms ± 0%250ms ± 0%−15.71%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-412.0ms ± 0%11.8ms ± 0%−1.50%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4114ms ± 0%115ms ± 0%+0.50%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.10s ± 0%1.05s ± 0%−4.38%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-447.9ms ± 0%46.5ms ± 0%−3.07%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4472ms ± 0%451ms ± 0%−4.46%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.94s ± 0%4.67s ± 0%−5.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4382µs ± 0%330µs ± 0%−13.46%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.18ms ± 0%3.80ms ± 0%−8.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-441.4ms ± 0%39.5ms ± 0%−4.44%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4396µs ± 0%363µs ± 0%−8.42%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.10ms ± 0%3.77ms ± 0%−8.13%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4308µs ± 0%282µs ± 0%−8.65%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.93ms ± 0%1.85ms ± 0%−4.16%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.9ms ± 0%24.3ms ± 0%−2.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4264µs ± 0%254µs ± 0%−3.59%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.95ms ± 0%1.88ms ± 0%−3.52%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4461µs ± 0%351µs ± 0%−23.90%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.44ms ± 0%1.28ms ± 0%−11.19%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-410.2ms ± 0%9.8ms ± 0%−3.95%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4571µs ± 0%478µs ± 0%−16.30%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.56ms ± 0%1.38ms ± 0%−11.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.2ms ± 0%10.2ms ± 0%−0.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4517µs ± 0%463µs ± 0%−10.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4501µs ± 0%543µs ± 0%+8.46%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4440µs ± 0%486µs ± 0%+10.54%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4783µs ± 0%720µs ± 0%−8.05%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4700µs ± 0%712µs ± 0%+1.81%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4642µs ± 0%643µs ± 0%+0.17%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4336µs ± 0%293µs ± 0%−12.89%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4346µs ± 0%286µs ± 0%−17.32%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4283µs ± 0%279µs ± 0%−1.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4469µs ± 0%465µs ± 0%−0.99%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.58ms ± 0%1.50ms ± 0%−4.86%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.4ms ± 0%12.4ms ± 0%−0.47%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-414.7µs ± 0%16.1µs ± 0%+9.46%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-416.4µs ± 0%14.7µs ± 0%−10.84%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-417.6µs ± 0%17.1µs ± 0%−2.83%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-418.5µs ± 0%15.9µs ± 0%−14.22%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-422.0µs ± 0%20.1µs ± 0%−8.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4157µs ± 0%125µs ± 0%−20.75%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4165µs ± 0%157µs ± 0%−4.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4169µs ± 0%155µs ± 0%−8.40%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4173µs ± 0%169µs ± 0%−2.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4224µs ± 0%196µs ± 0%−12.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-417.3µs ± 0%16.4µs ± 0%−5.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.4µs ± 0%16.8µs ± 0%−3.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-418.6µs ± 0%18.3µs ± 0%−1.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-421.5µs ± 0%20.9µs ± 0%−2.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-430.2µs ± 0%25.6µs ± 0%−15.37%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4165µs ± 0%161µs ± 0%−2.07%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4174µs ± 0%154µs ± 0%−11.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4181µs ± 0%164µs ± 0%−9.63%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4191µs ± 0%174µs ± 0%−8.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4226µs ± 0%206µs ± 0%−9.02%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-453.9µs ± 0%50.3µs ± 0%−6.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-453.8µs ± 0%50.9µs ± 0%−5.47%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-459.7µs ± 0%60.5µs ± 0%+1.41%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-460.4µs ± 0%60.8µs ± 0%+0.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-470.4µs ± 0%70.0µs ± 0%−0.63%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4386µs ± 0%432µs ± 0%+11.95%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4402µs ± 0%396µs ± 0%−1.56%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4416µs ± 0%405µs ± 0%−2.65%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4439µs ± 0%441µs ± 0%+0.48%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4568µs ± 0%502µs ± 0%−11.53%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-449.9µs ± 0%49.3µs ± 0%−1.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-450.9µs ± 0%60.5µs ± 0%+18.95%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-455.7µs ± 0%59.6µs ± 0%+7.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-462.5µs ± 0%59.9µs ± 0%−4.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-475.5µs ± 0%74.3µs ± 0%−1.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4388µs ± 0%415µs ± 0%+6.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4404µs ± 0%437µs ± 0%+8.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4461µs ± 0%409µs ± 0%−11.37%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4525µs ± 0%432µs ± 0%−17.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4592µs ± 0%516µs ± 0%−12.85%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4139µs ± 0%121µs ± 0%−12.91%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4138µs ± 0%132µs ± 0%−4.69%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4139µs ± 0%125µs ± 0%−10.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4146µs ± 0%139µs ± 0%−5.19%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4160µs ± 0%151µs ± 0%−5.50%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.29ms ± 0%1.23ms ± 0%−4.53%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.39ms ± 0%1.25ms ± 0%−9.91%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.29ms ± 0%1.26ms ± 0%−2.80%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.37ms ± 0%1.28ms ± 0%−6.73%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.56ms ± 0%1.40ms ± 0%−10.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4135µs ± 0%113µs ± 0%−16.11%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4131µs ± 0%120µs ± 0%−8.19%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4130µs ± 0%134µs ± 0%+3.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4134µs ± 0%132µs ± 0%−1.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4145µs ± 0%154µs ± 0%+6.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.24ms ± 0%1.23ms ± 0%−1.17%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.32ms ± 0%1.33ms ± 0%+0.72%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.43ms ± 0%1.28ms ± 0%−10.50%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.45ms ± 0%1.31ms ± 0%−9.35%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.63ms ± 0%1.43ms ± 0%−12.00%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-414.7µs ± 0%8.7µs ± 0%−40.98%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-412.0µs ± 0%9.1µs ± 0%−23.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.7µs ± 0%10.4µs ± 0%−2.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-416.4µs ± 0%12.0µs ± 0%−26.70%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-419.1µs ± 0%17.1µs ± 0%−10.73%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4114µs ± 0%116µs ± 0%+1.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4113µs ± 0%131µs ± 0%+15.95%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4117µs ± 0%139µs ± 0%+18.78%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4132µs ± 0%129µs ± 0%−2.82%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4182µs ± 0%164µs ± 0%−9.70%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4130µs ± 0%129µs ± 0%−1.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4132µs ± 0%131µs ± 0%−0.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4144µs ± 0%122µs ± 0%−14.86%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4141µs ± 0%125µs ± 0%−11.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4136µs ± 0%128µs ± 0%−5.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.27ms ± 0%1.17ms ± 0%−7.53%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.27ms ± 0%1.20ms ± 0%−5.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.40ms ± 0%1.24ms ± 0%−11.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.24ms ± 0%1.27ms ± 0%+2.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.33ms ± 0%1.29ms ± 0%−2.48%(p=1.000 n=1+1)
 

AndrewSisley
AndrewSisley approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot :)

@shahzadlone shahzadlone changed the title chore: Update ioutil package to io / os package. chore: Update ioutil package to io / os packages. Apr 26, 2022
@shahzadlone shahzadlone merged commit 27ffcf3 into develop Apr 26, 2022
@shahzadlone shahzadlone deleted the lone/chore/update-ioutil-package branch April 26, 2022 18:27
This was referenced Aug 16, 2022
Closed
Merged
shahzadlone added a commit that referenced this pull request Aug 18, 2022
@shahzadlone
tools: Ban the usage of ioutil package (#747)
cfbc4cb 
- Resolves #746

We did remove all usage of `ioutil` in: #376
However, over time it has crept back in a few times, this PR will enforce that it stays banned through the linter.
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
chore: Update ioutil package to io / os packages. (sourcenetwork#376)
c833795 
Resolves sourcenetwork#375
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
tools: Ban the usage of ioutil package (sourcenetwork#747)
f7c0f13 
- Resolves sourcenetwork#746

We did remove all usage of `ioutil` in: sourcenetwork#376
However, over time it has crept back in a few times, this PR will enforce that it stays banned through the linter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpheuslummis orpheuslummis orpheuslummis approved these changes

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@jsimnz jsimnz Awaiting requested review from jsimnz

@fredcarle fredcarle Awaiting requested review from fredcarle

Assignees

@shahzadlone shahzadlone

Labels
code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Update ioutil to io or os
4 participants
@shahzadlone @source-devs @orpheuslummis @AndrewSisley