Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban use of ioutil as it is deprecated #746

Closed
shahzadlone opened this issue Aug 16, 2022 · 0 comments · Fixed by #747
Closed

Ban use of ioutil as it is deprecated #746

shahzadlone opened this issue Aug 16, 2022 · 0 comments · Fixed by #747
Assignees
@shahzadlone
Labels
code quality Related to improving code quality deprecate Indicates something is deprecated.
Milestone
DefraDB v0.3.1

Comments

@shahzadlone
Copy link
Member

We did remove all usage of ioutil in: #376

However over time it has creeped back in, enforce it's ban through linter.
@shahzadlone shahzadlone added code quality Related to improving code quality deprecate Indicates something is deprecated. labels Aug 16, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3.1 milestone Aug 16, 2022
@shahzadlone shahzadlone self-assigned this Aug 16, 2022
@shahzadlone shahzadlone changed the title Ban use of ioutil as it is depricated Ban use of ioutil as it is deprecated Aug 16, 2022
@shahzadlone shahzadlone mentioned this issue Aug 16, 2022
Merged
4 tasks
shahzadlone added a commit that referenced this issue Aug 18, 2022
@shahzadlone
tools: Ban the usage of ioutil package (#747)
cfbc4cb 
- Resolves #746

We did remove all usage of `ioutil` in: #376
However, over time it has crept back in a few times, this PR will enforce that it stays banned through the linter.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
tools: Ban the usage of ioutil package (sourcenetwork#747)
f7c0f13 
- Resolves sourcenetwork#746

We did remove all usage of `ioutil` in: sourcenetwork#376
However, over time it has crept back in a few times, this PR will enforce that it stays banned through the linter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
code quality Related to improving code quality deprecate Indicates something is deprecated.
Projects
None yet
Milestone
DefraDB v0.3.1
Development

Successfully merging a pull request may close this issue.

tools: Ban the usage of ioutil package sourcenetwork/defradb
1 participant
@shahzadlone