Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging package created stdout file on file validation #665

Closed
fredcarle opened this issue Jul 26, 2022 · 0 comments · Fixed by #666
Closed

Logging package created stdout file on file validation #665

fredcarle opened this issue Jul 26, 2022 · 0 comments · Fixed by #666
Assignees
@fredcarle
Labels
area/logging Related to the logging/logger system bug Something isn't working
Milestone
DefraDB v0.3

Comments

@fredcarle
Copy link
Collaborator

The package is currently only validating stderr but stdout should also be validated.
@fredcarle fredcarle added bug Something isn't working area/logging Related to the logging/logger system labels Jul 26, 2022
@fredcarle fredcarle added this to the DefraDB v0.3 milestone Jul 26, 2022
@fredcarle fredcarle self-assigned this Jul 26, 2022
@fredcarle fredcarle mentioned this issue Jul 26, 2022
Merged
4 tasks
fredcarle added a commit that referenced this issue Jul 26, 2022
@fredcarle
fix: Add stdout validation when setting logging output path (#666)
c3d4517 
Relevant issue(s)
Resolves #665

Description
This PR fixes the outputPath validation for the logging package. It ensures an stdout file isn't created during validation.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
fix: Add stdout validation when setting logging output path (sourcene…
edad0ee 
…twork#666)

Relevant issue(s)
Resolves sourcenetwork#665

Description
This PR fixes the outputPath validation for the logging package. It ensures an stdout file isn't created during validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/logging Related to the logging/logger system bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging a pull request may close this issue.

fix: Add stdout validation when setting logging output path sourcenetwork/defradb
1 participant
@fredcarle