Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Ban the usage of ioutil package #747

Merged
merged 1 commit into from
Aug 18, 2022
Merged

tools: Ban the usage of ioutil package #747

merged 1 commit into from
Aug 18, 2022

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #746

Description

We did remove all usage of ioutil in: #376
However, over time it has crept back in a few times, this PR will enforce that it stays banned through the linter.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI & Locally

Specify the platform(s) on which this was tested:

  • Manjaro

@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality deprecate Indicates something is deprecated. labels Aug 16, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3.1 milestone Aug 16, 2022
@shahzadlone shahzadlone self-assigned this Aug 16, 2022
@shahzadlone shahzadlone changed the title tools: Enforce not using ioutil package tools: Ban the usage of ioutil package Aug 16, 2022
@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Aug 16, 2022
@source-devs

This comment was marked as spam.

Sign in to view
@shahzadlone shahzadlone force-pushed the lone/tools/ban-use-of-ioutils-enforced-with-linter branch from f1cc7a6 to 099b809 Compare August 16, 2022 10:54
fredcarle
fredcarle approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guilty of the first one... LGTM!

orpheuslummis
orpheuslummis approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone merged commit cfbc4cb into develop Aug 18, 2022
@shahzadlone shahzadlone deleted the lone/tools/ban-use-of-ioutils-enforced-with-linter branch August 18, 2022 04:00
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
tools: Ban the usage of ioutil package (sourcenetwork#747)
f7c0f13 
- Resolves sourcenetwork#746

We did remove all usage of `ioutil` in: sourcenetwork#376
However, over time it has crept back in a few times, this PR will enforce that it stays banned through the linter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

@orpheuslummis orpheuslummis orpheuslummis approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality deprecate Indicates something is deprecated.
Projects
None yet
Milestone
DefraDB v0.3.1
Development

Successfully merging this pull request may close these issues.

Ban use of ioutil as it is deprecated
4 participants
@shahzadlone @source-devs @orpheuslummis @fredcarle