Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commits: Remove commit query type #841

Closed
AndrewSisley opened this issue Sep 21, 2022 · 0 comments · Fixed by #879
Closed

Commits: Remove commit query type #841

AndrewSisley opened this issue Sep 21, 2022 · 0 comments · Fixed by #879
Assignees
@AndrewSisley
Labels
area/query Related to the query component code quality Related to improving code quality

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Sep 21, 2022 •
edited
Loading

Part of #549

Feature should be covered by all_commits.

This ticket needs to be done after #840 and #844
@AndrewSisley AndrewSisley added area/query Related to the query component code quality Related to improving code quality labels Sep 21, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.4 milestone Sep 21, 2022
This was referenced Sep 21, 2022
Closed
Closed
Closed
@AndrewSisley AndrewSisley self-assigned this Oct 6, 2022
@AndrewSisley AndrewSisley mentioned this issue Oct 7, 2022
Closed
AndrewSisley added a commit that referenced this issue Oct 11, 2022
@AndrewSisley
refactor: Remove commit query (#841)
ecb1d1f 
* Port commit tests with feature parity to allCommits

Moves the commit query tests that do not exist for allCommits, where the behaviour matches exactly (copy-paste with name changes).

* Port commit tests with corrected behaviour

Moves the commit test(s) to allCommits where the behaviour of commit was incorrect, but correct in allCommits, and where allCommits was previously untested.

* Remove commit tests that already exist for allCommits

Removes commit tests for behaviour that is already tested by existing commit tests.

* Remove commit test that is not applicable for allCommits

* Remove commit test utils

* Remove commit query

* Move allCommits tests

No code changes, just moved the files (sperate commit to make it easier to spot changes)

* Rename allCommits to commits
@AndrewSisley AndrewSisley linked a pull request Oct 11, 2022 that will close this issue
refactor: Rename all commits to commits #879
Merged
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
refactor: Remove commit query (sourcenetwork#841)
7869986 
* Port commit tests with feature parity to allCommits

Moves the commit query tests that do not exist for allCommits, where the behaviour matches exactly (copy-paste with name changes).

* Port commit tests with corrected behaviour

Moves the commit test(s) to allCommits where the behaviour of commit was incorrect, but correct in allCommits, and where allCommits was previously untested.

* Remove commit tests that already exist for allCommits

Removes commit tests for behaviour that is already tested by existing commit tests.

* Remove commit test that is not applicable for allCommits

* Remove commit test utils

* Remove commit query

* Move allCommits tests

No code changes, just moved the files (sperate commit to make it easier to spot changes)

* Rename allCommits to commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/query Related to the query component code quality Related to improving code quality
Projects
None yet
Milestone
No milestone
1 participant
@AndrewSisley