Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing WithStack function for defra errors package #869

Closed
fredcarle opened this issue Oct 5, 2022 · 0 comments · Fixed by #870
Closed

missing WithStack function for defra errors package #869

fredcarle opened this issue Oct 5, 2022 · 0 comments · Fixed by #870
Assignees
@fredcarle
Labels
area/errors Related to the internal management or design of our error handling system

Comments

@fredcarle
Copy link
Collaborator

No description provided.

@fredcarle fredcarle self-assigned this Oct 5, 2022
@fredcarle fredcarle added the area/errors Related to the internal management or design of our error handling system label Oct 5, 2022
@fredcarle fredcarle added this to the DefraDB v0.4 milestone Oct 5, 2022
@fredcarle fredcarle mentioned this issue Oct 5, 2022
Merged
fredcarle added a commit that referenced this issue Oct 5, 2022
@fredcarle
feat: Add WithStack to the errors package (#870)
fc77438 
Relevant issue(s)
Resolves #869

Description
This PR adds a WithStack function to the errors package to be able to add a stacktrace to a returned error without adding a message. It also fixes the TestErrorIs unit test.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
feat: Add WithStack to the errors package (sourcenetwork#870)
277442e 
Relevant issue(s)
Resolves sourcenetwork#869

Description
This PR adds a WithStack function to the errors package to be able to add a stacktrace to a returned error without adding a message. It also fixes the TestErrorIs unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/errors Related to the internal management or design of our error handling system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add WithStack to the errors package sourcenetwork/defradb
1 participant
@fredcarle