Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log request elapsed time to relative suffix #899

Closed
jsimnz opened this issue Oct 14, 2022 · 2 comments · Fixed by #910
Closed

Change log request elapsed time to relative suffix #899

jsimnz opened this issue Oct 14, 2022 · 2 comments · Fixed by #910
Assignees
@fredcarle
Labels
area/logging Related to the logging/logger system refactor This issue specific to or requires *notable* refactoring of existing codebases and components

Comments

@jsimnz
Copy link
Member

jsimnz commented Oct 14, 2022

At the moment, all request logs include an "elapsed" paramater. This is always expressed in the unit of seconds, but all our queries are dumb fast compared to order of seconds. Eg: "ElapsedSeconds": 0.00080469

So instead, we should report time in the closest relative magnitude (ie: s, ms, ns), so the above would read "ElapsedSeconds": 0.80469ms.
@jsimnz jsimnz added this to the DefraDB v0.4 milestone Oct 14, 2022
@jsimnz jsimnz added area/logging Related to the logging/logger system refactor This issue specific to or requires *notable* refactoring of existing codebases and components labels Oct 14, 2022
@jsimnz jsimnz changed the title Change log request time to relative suffix Change log request elapsed time to relative suffix Oct 14, 2022
@fredcarle fredcarle self-assigned this Oct 17, 2022
@orpheuslummis
Copy link
Contributor

"ElapsedMilliseconds": 0.80469 ?

@fredcarle
Copy link
Collaborator

"ElapsedTime": 0.80468ms

@fredcarle fredcarle mentioned this issue Oct 21, 2022
Merged
4 tasks
fredcarle added a commit that referenced this issue Oct 21, 2022
@fredcarle
fix: Change time format for HTTP API log (#910)
9490679 
Relevant issue(s)
Resolves #899

Description
This PR changes the formatting of the elapsed time in the logs from requests to the HTTP API.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
fix: Change time format for HTTP API log (sourcenetwork#910)
75897b1 
Relevant issue(s)
Resolves sourcenetwork#899

Description
This PR changes the formatting of the elapsed time in the logs from requests to the HTTP API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/logging Related to the logging/logger system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Change time format for HTTP API log sourcenetwork/defradb
3 participants
@orpheuslummis @jsimnz @fredcarle