Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change time format for HTTP API log #910

Merged
merged 1 commit into from
Oct 21, 2022
Merged

fix: Change time format for HTTP API log #910

merged 1 commit into from
Oct 21, 2022

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #899

Description

This PR changes the formatting of the elapsed time in the logs from requests to the HTTP API.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

manually tested and visually confirmed

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added area/api Related to the external API component action/no-benchmark Skips the action that runs the benchmark. labels Oct 21, 2022
@fredcarle fredcarle added this to the DefraDB v0.4 milestone Oct 21, 2022
@fredcarle fredcarle requested a review from a team October 21, 2022 00:22
@fredcarle fredcarle self-assigned this Oct 21, 2022
@fredcarle fredcarle changed the title change time format for HTTP API log fix: Change time format for HTTP API log Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #910 (89a56e5) into develop (f96fe72) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #910   +/-   ##
========================================
  Coverage    59.79%   59.79%           
========================================
  Files          156      156           
  Lines        17415    17415           
========================================
  Hits         10414    10414           
  Misses        6065     6065           
  Partials       936      936
Impacted Files Coverage Δ
api/http/logger.go 100.00% <100.00%> (ø)

shahzadlone
shahzadlone approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EZPZ, like we discussed in last standup.

@fredcarle fredcarle merged commit 9490679 into develop Oct 21, 2022
@fredcarle fredcarle deleted the fredcarle/fix/I899-http-api-elapsedtime branch October 21, 2022 14:14
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@fredcarle
fix: Change time format for HTTP API log (sourcenetwork#910)
75897b1 
Relevant issue(s)
Resolves sourcenetwork#899

Description
This PR changes the formatting of the elapsed time in the logs from requests to the HTTP API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@fredcarle fredcarle

Labels
action/no-benchmark Skips the action that runs the benchmark. area/api Related to the external API component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change log request elapsed time to relative suffix
2 participants
@fredcarle @shahzadlone