Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme typo for p2p replicator example (wrong port) #954

Closed
jsimnz opened this issue Nov 25, 2022 · 0 comments · Fixed by #960
Closed

Readme typo for p2p replicator example (wrong port) #954

jsimnz opened this issue Nov 25, 2022 · 0 comments · Fixed by #960
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@jsimnz
Copy link
Member

jsimnz commented Nov 25, 2022

Currently:
defradb client rpc addreplicator "Article" /ip4/0.0.0.0/tcp/9162/p2p/<peerID_of_nodeB>

Needs to be:
defradb client rpc addreplicator "Article" /ip4/0.0.0.0/tcp/9172/p2p/<peerID_of_nodeB>

@jsimnz jsimnz added bug Something isn't working documentation Improvements or additions to documentation labels Nov 25, 2022
@jsimnz jsimnz added this to the DefraDB v0.4 milestone Nov 25, 2022
@fredcarle fredcarle self-assigned this Dec 6, 2022
fredcarle added a commit that referenced this issue Dec 15, 2022
Relevant issue(s) 
#462
#955
#954
#952

Description
This PR adds the ability to persist P2P replicators. It change to RPC part of the CLI to have a new sub command which is replicator.

Using that sub command, we can add, delete and getAll to operate on the replicator store.

Note: Using the config file to add replicators will be done in a future PR. Will most likely add integration test before merging this PR.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
Relevant issue(s) 
sourcenetwork#462
sourcenetwork#955
sourcenetwork#954
sourcenetwork#952

Description
This PR adds the ability to persist P2P replicators. It change to RPC part of the CLI to have a new sub command which is replicator.

Using that sub command, we can add, delete and getAll to operate on the replicator store.

Note: Using the config file to add replicators will be done in a future PR. Will most likely add integration test before merging this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants