Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove secret ssh key stuff from change detector wf #1438

Merged
merged 1 commit into from
May 1, 2023
+1 −8
Merged

ci: Remove secret ssh key stuff from change detector wf #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/detect-change.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,6 @@ jobs:
make deps:modules
make deps:test

# We need SSH Authorization because change detection needs use `ls-remote` like:
# git ls-remote [email protected]:sourcenetwork/defradb.git refs/heads/develop
- uses: webfactory/[email protected]
with:
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}
log-public-key: false

- name: Run detection for changes
run: make test:changes

Expand Down
2 changes: 1 addition & 1 deletion tests/integration/utils2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func init() {
SetupOnly = getBool(setupOnlyValue)

if !repositorySpecified {
repositoryValue = "git@github.com:sourcenetwork/defradb.git"
repositoryValue = "https://github.com/sourcenetwork/defradb.git"
}

if !targetBranchSpecified {
Expand Down