fix: Reference collectionID in p2p readme #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
documentation
AndrewSisley
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1466 +/- ##
===========================================
- Coverage 72.23% 72.19% -0.05%
===========================================
Files 185 185
Lines 18224 18224
===========================================
- Hits 13165 13157 -8
- Misses 4024 4030 +6
- Partials 1035 1037 +2 |
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1465 ## Description Reference collectionID instead of schemaVersionID in p2p readme. I think this wording might predate the introduction of the collectionID field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1465
Description
Reference collectionID instead of schemaVersionID in p2p readme. I think this wording might predate the introduction of the collectionID field.