Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make nested joins work correctly from primary direction #1491

Merged
merged 6 commits into from
May 10, 2023
Merged

fix: Make nested joins work correctly from primary direction #1491

merged 6 commits into from
May 10, 2023

Commits on May 10, 2023

  1. Migrate one-one-one test to new framework 

    No changes to the test content
    @AndrewSisley
    AndrewSisley committed May 10, 2023
    Configuration menu
    Copy the full SHA
    5a328d6 View commit details
    Browse the repository at this point in the history

  2. Cleanup one-one-one test 

    Removes the extra fields from the schema, and reorders stuff so that it is read in the order that it is used. Does also change the test itself, so that now it does actually test from the primary direction all the way through.
    @AndrewSisley
    AndrewSisley committed May 10, 2023
    Configuration menu
    Copy the full SHA
    5218029 View commit details
    Browse the repository at this point in the history

  3. Do not propagate spans to subTypes 

    This results in the scan nodes of the inner most query (subType) trying to scan with the parent prefix - e.g. reading books from within the [publisher][doc1] prefix.
    @AndrewSisley
    AndrewSisley committed May 10, 2023
    Configuration menu
    Copy the full SHA
    783b9b7 View commit details
    Browse the repository at this point in the history

  4. Add one-one-many tests 

    Some of these would fail before the fix was implemented.
    @AndrewSisley
    AndrewSisley committed May 10, 2023
    Configuration menu
    Copy the full SHA
    990dcac View commit details
    Browse the repository at this point in the history

  5. Expand one-one-one tests 

    Some of these would fail before the fix was implemented.
    @AndrewSisley
    AndrewSisley committed May 10, 2023
    Configuration menu
    Copy the full SHA
    268b4c0 View commit details
    Browse the repository at this point in the history

  6. PR FIXUP - Document false-negative change detector

    @AndrewSisley
    AndrewSisley committed May 10, 2023
    Configuration menu
    Copy the full SHA
    f4e3016 View commit details
    Browse the repository at this point in the history