Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db query testing expansion part 2 #15

Merged
merged 34 commits into from
Oct 25, 2021
Merged

Conversation

AndrewSisley
Copy link
Contributor

A continuation of #14 (branch db-query-testing-expansion), this completes the breakup of db/query_tests.go

Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I like the break-up of tests compared to the giant dump from the original file.

@AndrewSisley AndrewSisley merged commit dc23dce into master Oct 25, 2021
@AndrewSisley AndrewSisley deleted the db-query-testing-expansion-2 branch October 25, 2021 13:39
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
…ng-expansion-2

Db query testing expansion part 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants