test(i): Restructure mutation integration test dir #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing tests will be moved here as they are updated, and then new ones will be defined. Sub-directories will be added in later commits.
And convert them to the newer test framework, and tweak a few to make use of the mutation-test action magic.
Notable changes: - The datetime boolean tests have been removed - the boolean filter param is irrelevant to the datetime field type and it only complicates the reading of the test without offering any significant advantage RE protection. - The datetime ids tests have been removed for the same reason as the boolean filter tests. - A test using an UpdateDoc test action has been added, this gives basic coverage of the field type happy path - A test using an update request has been added, this ensures that updating multiple docs in a single request is functional. - All references to the dockeys have been removed, returning them in the query protects against very-little at best here whilst incuring an annoying maintanence cost. The withFilter tests remain as is, whilst they are really not comprehensive, they do cover the tests removed from with_datetime_test, and are not particularly relevant to the goal of this PR (which has nothing to do with filters).
Also updates them to the new framework
Also updates them to the new framework
Also updates them to the new framework
Also updates them to the new framework
Also updates them to the new framework
Also updates them to the new framework
Also updates them to the new framework
Also updates them to the new framework
No test changes, all were already using the new framework
No test changes, all were already using the new framework
No test changes, all were already using the new framework
No test changes, all were already using the new framework
No test changes, all were already using the new framework
No test changes, all were already using the new framework
No test changes, all were already using the new framework
Also converts a few remaining on the old framework to the new framework.
And convert them to the newer test framework.
And convert them to newer framework.
AndrewSisley
added
area/testing
Codecov ReportPatch coverage has no change and project coverage change:
@@ Coverage Diff @@
## develop #1848 +/- ##
===========================================
- Coverage 75.71% 75.54% -0.18%
===========================================
Files 209 209
Lines 22261 22261
===========================================
- Hits 16854 16815 -39
- Misses 4237 4283 +46
+ Partials 1170 1163 -7
Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Cheers for sorting out! Looking forward to resolving the conflicts within #1749 😆
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1847 ## Description Restructures mutation integration test dir. The previous structure did not offer adequate levels of test discoverability, and as we really need to add more tests here, it needed sorting out. Also, all tests (I think) in the `mutation` directory have been migrated to the newer test framework. A handful have been deleted, as the restructuring highlight a few duplicates. Some schemas have also been simplified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1847
Description
Restructures mutation integration test dir.
The previous structure did not offer adequate levels of test discoverability, and as we really need to add more tests here, it needed sorting out.
Also, all tests (I think) in the
mutationdirectory have been migrated to the newer test framework. A handful have been deleted, as the restructuring highlight a few duplicates. Some schemas have also been simplified.Two production bugs tickets were opened during this work:
_deletedfield returns false for records in delete mutation #1846The scope of the work in this PR shifted after the first two commits as I realised it would be more effort than I first thought, as such the 2nd and 3rd commits do quite a lot. I want to further improve the tests moved in the other commits in a similar way, however this is already a very large PR, and I instead will do that in another block of work.
The commits are not as clean as I would like, but reviewing commit by commit will help you guys see where stuff has moved.