Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Convert and move out of place explain tests #1878

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #1547

Description

  • Move some explain tests that should have been under the explain directory, they seemed to have been missed converting to the new explain setup.

@shahzadlone shahzadlone added the area/testing Related to any test or testing suite label Sep 14, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.7 milestone Sep 14, 2023
@shahzadlone shahzadlone requested a review from a team September 14, 2023 14:41
@shahzadlone shahzadlone self-assigned this Sep 14, 2023
@shahzadlone shahzadlone force-pushed the lone/test/move-explain-tests-where-they-belong branch from cb1e44f to 752fc63 Compare September 14, 2023 14:45
@shahzadlone shahzadlone force-pushed the lone/test/move-explain-tests-where-they-belong branch from 752fc63 to b31e934 Compare September 14, 2023 14:49
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@6789b44). Click here to learn what that means.
Patch has no changes to coverable lines.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1878   +/-   ##
==========================================
  Coverage           ?   70.23%           
==========================================
  Files              ?      232           
  Lines              ?    24192           
  Branches           ?        0           
==========================================
  Hits               ?    16989           
  Misses             ?     6035           
  Partials           ?     1168           
Flag Coverage Δ
all-tests 70.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6789b44...34f4490. Read the comment docs.

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers Shahzad

@shahzadlone shahzadlone merged commit 9ec97d5 into sourcenetwork:develop Sep 14, 2023
14 checks passed
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)
Resolves sourcenetwork#1547 

## Description
- Move some explain tests that should have been under the explain
directory, they seemed to have been missed converting to the new explain
setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are some explain tests outside the explain test dir that assert index join behavior
2 participants