Issue 22: remove schemaless code branches #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schemaless is no longer supported
Schemaless is no longer supported, tests required a few tweaks here as they did not provide schemas
jsimnz
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
I believe thats all the important code branches.
The only left over ones that aren't addressed are contained withi the document package. But those are somewhat unique. At the moment, the collection almost entirely relies on the its own schema description for validation, and not whats stored within a document.Document instance.
If you want to update the document package you can, but I think this PR is good as is :)
|
Okay cheers, will merge and have a look at the doc package later hopefully |
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…emaless Issue 22: remove schemaless code branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldnt spot any others, please let me know if you know otherwise :)