Ensure OperationDefinition case has at least one selection #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Posibly theoretical, but is an easy todo to kill off and its better to have the defensive code than a panic
|
A whole branch PR is a tad overkill here perhaps, but it is an indepentant todo... |
jsimnz
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
If you rebase this off of master, the build should pass.
As for the size of the PR thats OK 😂. I wasn't too worried about this possible branch because the GraphQL parser would complain before we got to this point.
However, in the instance where you manually create the *parser.Query object this could be a condition, so its good to have this covered.
jsimnz
requested changes
Nov 2, 2021
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…ast-one-selection Ensure OperationDefinition case has at least one selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posibly theoretical, but is an easy todo to kill off and its better to have the defensive code than a panic