Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Purge all println and ban it #253

Merged
merged 7 commits into from
Mar 1, 2022
Merged

refactor: Purge all println and ban it #253

merged 7 commits into from
Mar 1, 2022

Commits on Mar 1, 2022

  1. Use logger in bench package

    @AndrewSisley
    AndrewSisley committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    fb36176 View commit details
    Browse the repository at this point in the history

  2. Log command result instead of println

    @AndrewSisley
    AndrewSisley committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    f7a9eca View commit details
    Browse the repository at this point in the history

  3. Remove printlns from db_test 

    Here they are actually hidding what is actually untested
    @AndrewSisley
    AndrewSisley committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    ffb6056 View commit details
    Browse the repository at this point in the history

  4. Write to log in db.printstore 

    Instead of println
    @AndrewSisley
    AndrewSisley committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    01c4366 View commit details
    Browse the repository at this point in the history

  5. Use logger in db.tests

    @AndrewSisley
    AndrewSisley committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    4348f0d View commit details
    Browse the repository at this point in the history

  6. Delete println

    @AndrewSisley
    AndrewSisley committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    804cdb3 View commit details
    Browse the repository at this point in the history

  7. Ban fmt.PrintX

    @AndrewSisley
    AndrewSisley committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    56d72e5 View commit details
    Browse the repository at this point in the history