chore: Bump to GoLang v1.22 #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
force-pushed
the
lone/bump-go-lang-1-22
branch
from
c746c7e
to
4c1b632
Compare
AndrewSisley
approved these changes
Aug 26, 2024
| @@ -157,11 +157,7 @@ func getCollectionHistory( | |||
| history := map[schemaVersionID]*collectionHistoryLink{} | |||
| schemaVersionsByColID := map[uint32]schemaVersionID{} | |||
|
|
|||
| for _, c := range cols { | |||
| // Todo - this `col := c` can be removed with Go 1.22: | |||
| // https://github.com/sourcenetwork/defradb/issues/2431 | |||
There was a problem hiding this comment.
praise: Thanks for removing this and the others :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2913 +/- ##
===========================================
- Coverage 79.39% 79.36% -0.03%
===========================================
Files 326 326
Lines 24772 24768 -4
===========================================
- Hits 19667 19656 -11
- Misses 3696 3701 +5
- Partials 1409 1411 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
force-pushed
the
lone/bump-go-lang-1-22
branch
from
4c1b632
to
4e214d9
Compare
Terraform Format and Style
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2431
Description